-
-
Notifications
You must be signed in to change notification settings - Fork 3
Trac bugtracker support #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Details result fixed.
…determines Postgres client version.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good as a start but it needs some improvements and there are several open questions which need answers/resolution.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
===========================================
- Coverage 95.28% 80.00% -15.29%
===========================================
Files 17 19 +2
Lines 615 760 +145
===========================================
+ Hits 586 608 +22
- Misses 29 152 +123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@FrankSommer-64 just a reminder for whenever you are able to get back to this: Please copy test_mantis.py into a test_trac.py file and adjust it accordingly so we can see the new integration being exercised. Once we have logs (know how it works) I can continue with the review. |
I adapted test_mantis.py to test_trac.py. There's one problem left: how to cope with product name, as it must be the same in KiwiTCMS and Trac. In contrast to Mantis you can't create a Trac product using API/browser, that must be done when starting the docker container. Can a fix name be used (in Trac container yes), or will it cause trouble in KiwiTCMS instance when repeating tests (product already exists) ? |
Can you push the code so I can see exactly what's going on. Don't know this answer at the top of my head.
|
…zable with environment variables. Pylint warnings fixed. Test module added.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some changes. Please also see this failing CI job: https://github.com/kiwitcms/trackers-integration/actions/runs/17983996551/job/51226057670?pr=88
""" | ||
:meta private: | ||
Proxy class for Trac ticket JSON-RPC interface. | ||
Trac server must have plugin trac-ticketrpc installed (https://pypi.org/project/trac-ticketrpc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be duplicated into the main Trac
class too.
@@ -0,0 +1,3 @@ | |||
passlib | |||
trac == 1.6 | |||
trac_ticketrpc == 0.9.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this directory to https://github.com/kiwitcms/trackers-integration/blob/main/.github/dependabot.yml
# Licensed under GNU Affero General Public License v3 or later (AGPLv3+) | ||
# https://www.gnu.org/licenses/agpl-3.0.html | ||
|
||
FROM python:3.11-slim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this directory to https://github.com/kiwitcms/trackers-integration/blob/main/.github/dependabot.yml
src = | ||
|
||
[project] | ||
descr = Kiwi integration with Trac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
descr = Kiwi integration with Trac | |
descr = Kiwi TCMS integration with Trac |
self.project_name = os.getenv("TRAC_PRODUCT", "MyProject") | ||
|
||
def _fixture_setup(self): | ||
super()._fixture_setup() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing b/c in latest versions Django has changed this method. See #91 for the relevant changes necessary.
Contribution provides support for Trac bugtracker from Kiwi TCMS.
Requires Trac version 1.6 or above, and Plugin trac-ticketrpc installed and enabled in Trac server (see documentation on https://pypi.org/project/trac-ticketrpc/).
Docker files for tests against Trac server are included, automated tests to be implemented.