-
Couldn't load subscription status.
- Fork 11
2.1.0 Release #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.1.0 Release #266
Conversation
* First pass at 0.78 -> 0.79.5 * Actually bump from 0.78->0.79.5 * Runs on example app, test app remote, test app local * 0.80.2 bump * add backwards moduleResolution fix * oops remove test ID * Some android-specific tweaks for 0.80 * Adjust the runner type and xcode version --------- Co-authored-by: Evan Masseau <>
b84403f to
224a243
Compare
* Consume universal links branches of mobile SDKs (#258) [REVERT] consume universal links branches of mobile SDKs * [CHNL-24361] add handleUniversalTrackingLink (#256) * added `handleTrackingLink` method * added documentation * added URL validation and error handling * added unit tests * [CHNL-24361] add handleUniversalTrackingLink (Android) (#257) * added `handleTrackingLink` method * added documentation * added URL validation and error handling * added unit tests * added `handleUniversalTrackingLink` method * [CHNL-24362][iOS] inject deep link handler (#260) * added `KlaviyoDeepLinkAPI` interface * added KlaviyoDeepLinkEventEmitter * added `registerDeepLinkHandler` to KlaviyoBridge * export KlaviyoDeepLinkEventEmitter * updated `Klaviyo.ts` * implemented `registerDeepLinkHandler` logic * [CHNL-24362][Android] wired up Android deep link handler (#261) * wired up Android deep link handler * Additional android tweaks for universal linking * Synchronously return whether the link is going to be handled by Klaviyo sdk --------- Co-authored-by: Evan Masseau <> * Fix mistake in this test, must not have been detected by CI because of funky branching at the time. * Universal link fixes (#269) * turns out the URL object is unusable on react (knew it was too good to be true) * tweak example app to clarify use of the return value. remove register handler while i'm here. * leave this change to andrew's PR. --------- Co-authored-by: Evan Masseau <> * Remove registerDeepLinkHandler (#270) removed all `registerDeepLinkHandler` code * Remove the unneeded android deep link emitter stuff (#271) Co-authored-by: Evan Masseau <> * Update native SDK targets * Update example/src/App.tsx Co-authored-by: Andrew Balmer <[email protected]> * oh dear github. --------- Co-authored-by: Andrew Balmer <[email protected]> Co-authored-by: Evan Masseau <>
* Set uniqueId * back to 4.1.0 * Safer typing on unique ID. unrelated, but don't give klaviyo a null initial url --------- Co-authored-by: Evan Masseau <>
adding code to RN example app
* comitting readme updates for universal linking * removed some redundant content in the readme * minor fixes
android/gradle.properties
Outdated
| # org.gradle.parallel=true | ||
| #Tue Dec 19 15:08:27 EST 2023 | ||
| KlaviyoReactNativeSdk_klaviyoAndroidSdkVersion=4.0.1 | ||
| KlaviyoReactNativeSdk_klaviyoAndroidSdkVersion=rel~4.1.0-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These versions get cleaned up later yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in #275
example/ios/Podfile
Outdated
| use_frameworks! :linkage => :static | ||
|
|
||
| # Insert override klaviyo-swift-sdk pods below this line when needed | ||
| pod 'KlaviyoCore', :git => 'https://github.com/klaviyo/klaviyo-swift-sdk.git', :branch => 'master' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here... should be udpated yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in #275
| <key>NSExtensionPrincipalClass</key> | ||
| <string>$(PRODUCT_MODULE_NAME).NotificationService</string> | ||
| </dict> | ||
| <key>RCTNewArchEnabled</key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming most of this was approved earlier just checking this is intentional.
|
|
||
| // Validate that the URL is a Klaviyo universal tracking link using regex | ||
| // Pattern: https://domain/u/path | ||
| const klaviyoTrackingLinkPattern = /^https:\/\/[^/]+\/u\/.*$/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhhh...do we need this code in here too? Doesn't the native code handle this or do we want an immediate response back?
* Bump SDK version to 2.1.0 * Bump Android to 4.1.0 * Remove temp hack pointing swift to master * Pull in Swift 5.1.0 SDK
Description
Intended contents of this release:
Due Diligence
Release/Versioning Considerations
PatchContains internal changes or backwards-compatible bug fixes.MinorContains changes to the public API.MajorContains breaking changes.Changelog / Code Overview
Test Plan
Related Issues/Tickets
Note
Upgrade RN to 0.80.2 and native SDKs (iOS 5.1.0, Android 4.1.0), add universal tracking link handling API, event uniqueId support, in‑app forms updates, and refresh examples/docs/configs.
Klaviyo.handleUniversalTrackingLink(url)across JS (src/index.tsx), iOS (KlaviyoBridge,KlaviyoReactNativeSdk.mm), and Android (KlaviyoReactNativeSdkModule.kt).uniqueIdon events (JS → iOS/Android bridges).2.1.0(package.json, iOS/Android version resources) and depend onKlaviyoSwift 5.1.0/KlaviyoForms 5.1.0(.podspec).0.80.2(packages, example app, pods) and Hermes/tooling updates.4.1.0(android/gradle.properties); Gradle wrapper →8.14.1.2.1.20; iOS adds new-arch flags and associated domains for Universal Links.https://.../u/tracking links; updateMainApplicationinit to new RN APIs.continueUserActivityhandling, entitlements for Associated Domains; formatting/initialization tweaks.Klaviyo.handleUniversalTrackingLink.Linkingexample; update In‑App Forms feature matrix (adds Event Triggers); minor cleanup.handleUniversalTrackingLinkvalidation/dispatch and eventuniqueId.Written by Cursor Bugbot for commit 0e6d909. This will update automatically on new commits. Configure here.