Fixes to work with Python 3.12+ #254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Eliminate the use of pkg_resources which is no longer installed with Python 3.12 and greater. - Add setuptools to requirements.txt which is no longer included in Python distributions (>= 3.12).
This was referenced Jul 7, 2024
|
Ping? |
|
Can this PR be merged, please? |
|
Maybe ping @klen in case it went unnoticed It seems that even installing setuptools manually will stop working soon
|
|
ping @klen :) Can this PR be merged, please, it's very annoying to suppress warnings in CI and it freaks me out that pylama would stop working after CI pipelines upgrade to python 3.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the dependence on
pkg_resourceswhich is not available by default in Python 3.12 and beyond. It switches frompkg_resources.iter_entry_pointstoimport_metadata.entry_points.import_metadatais available in all supported versions of Python.The other change removes the use of
parse_requirementsand just hardcodes the package dependencies insetup.py, which is arguably good practice anyway since not all developer-installed packages are required by the installation.Finally,
setuptoolsis added torequirements.txtsince it is also no longer installed by default with Python 3.12.