-
Notifications
You must be signed in to change notification settings - Fork 165
Add StartTimeout handling to Docker Runner #3135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StartTimeout handling to Docker Runner #3135
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3135 +/- ##
==========================================
+ Coverage 58.31% 58.69% +0.38%
==========================================
Files 134 134
Lines 17377 17397 +20
==========================================
+ Hits 10134 10212 +78
+ Misses 6302 6214 -88
- Partials 941 971 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @gauron99 , Please can you review this one ? if you have a moment. |
lkingland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This might be a duplicate PR?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: intojhanurag, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR adds
StartTimeoutsupport to the Docker Runner (pkg/docker/runner.go).The Runner now waits for the container to become ready within a configurable timeout and returns an error if it does not start in time.