-
Notifications
You must be signed in to change notification settings - Fork 165
feat: add interactive prompts for builder, push, and builder image options #3149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add interactive prompts for builder, push, and builder image options #3149
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3149 +/- ##
==========================================
+ Coverage 59.39% 60.02% +0.62%
==========================================
Files 134 134
Lines 13495 13540 +45
==========================================
+ Hits 8016 8128 +112
+ Misses 4538 4442 -96
- Partials 941 970 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hmm Im thinking to include only the necessary options. Keep the optional ones out of the prompts. (remove the builderImage and base image since its only host builder -- or do a conditional check for baseImage only if host builder is used. |
|
/ok-to-test |
gauron99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a prompt test already in use where we could add test cases for these new prompts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there a change to third party?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's interesting. The check might fail asking to "update codegen" if this is a real problem (probably an IDE autocleanup or other)
cmd/build.go
Outdated
| { | ||
| Name: "baseImage", | ||
| Prompt: &survey.Input{ | ||
| Message: "Optional base image for your function (host builder only):", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Message: "Optional base image for your function (host builder only):", | |
| Message: "Optional base image for your function (empty for default):", |
from the user perspective, is it left empty if they dont provide a value? In other words is the default shown in the prompt? if not I would suggest this.
|
Hey @gauron99 , I added the all suggestion. Please take a look on it . |
lkingland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The changes in third_party may have been inadvertent, but innocuous
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: intojhanurag, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Adds interactive prompts to
func build --confirmfor additional build options, including:--builder)--push)--builder-image)--base-image)Before
After