Skip to content

Conversation

@intojhanurag
Copy link
Contributor

Changes

Adds interactive prompts to func build --confirm for additional build options, including:

  • Builder selection (--builder)
  • Push option (--push)
  • Builder image (--builder-image)
  • Base image (--base-image)

Before

Screenshot 2025-10-26 124916

After

Screenshot 2025-10-26 124222

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 26, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

❌ Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.02%. Comparing base (39c321d) to head (a583f58).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
cmd/build.go 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3149      +/-   ##
==========================================
+ Coverage   59.39%   60.02%   +0.62%     
==========================================
  Files         134      134              
  Lines       13495    13540      +45     
==========================================
+ Hits         8016     8128     +112     
+ Misses       4538     4442      -96     
- Partials      941      970      +29     
Flag Coverage Δ
e2e-tests 41.55% <0.00%> (+1.32%) ⬆️
integration-tests 54.57% <0.00%> (+1.56%) ⬆️
unit-tests 46.63% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99
Copy link
Contributor

Hmm Im thinking to include only the necessary options. Keep the optional ones out of the prompts. (remove the builderImage and base image since its only host builder -- or do a conditional check for baseImage only if host builder is used.

@gauron99
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2025
@gauron99 gauron99 self-assigned this Nov 1, 2025
@gauron99 gauron99 requested review from lkingland and removed request for dsimansk and jrangelramos November 1, 2025 12:52
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a prompt test already in use where we could add test cases for these new prompts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there a change to third party?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting. The check might fail asking to "update codegen" if this is a real problem (probably an IDE autocleanup or other)

cmd/build.go Outdated
{
Name: "baseImage",
Prompt: &survey.Input{
Message: "Optional base image for your function (host builder only):",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Message: "Optional base image for your function (host builder only):",
Message: "Optional base image for your function (empty for default):",

from the user perspective, is it left empty if they dont provide a value? In other words is the default shown in the prompt? if not I would suggest this.

@intojhanurag
Copy link
Contributor Author

Hey @gauron99 , I added the all suggestion. Please take a look on it .

Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
The changes in third_party may have been inadvertent, but innocuous

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: intojhanurag, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@knative-prow knative-prow bot merged commit 328380c into knative:main Nov 11, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants