Skip to content

Conversation

@sofusalbertsen
Copy link
Contributor

No description provided.

Copy link
Contributor

@dangrondahl dangrondahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on "Best practice"

* CD part: name your flow "release-name"
* Trail:
* Default to SHA
* Others could be release version (Git tag), merge number etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be covered by Semantic Versioning, e.g:
v1.0.0-[build]+[sha]


Centralized pipelines means that you will get a lot of flows based on the same template.

Solution; Add tags to your flows so that all with the same "template" will have the same tag. In that way you do not need to know the name, but can evaluate based on tags.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider if tagging should have it's own section or page, since it spans different resources (envs, flows, etc.).

Only page I find on tagging is:
https://docs.kosli.com/client_reference/kosli_tag/

Which is more CLI reference than conceptual. Also reported this small bug on the page:
#553


An example of that would be the Cyber-Dojo environment policy repository on [Github](https://github.com/cyber-dojo/kosli-environment-policies).

In that repository we have four poilicices attached:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In that repository we have four poilicices attached:
In that repository we have four policices attached:


When creating policies, we have found it best to split up policies into their logical units. That way, it is easier to maintain and understand the logical connection between requirements.

An example of that would be the Cyber-Dojo environment policy repository on [Github](https://github.com/cyber-dojo/kosli-environment-policies).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea for future considerations:

  • Create a kosli-dev/policy-store repo
  • Store has templates for common policies (Go templating)
  • A functionality (in the CLI) to point to a template and interactively create policy from input.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I'd like to discuss - we need a way to "promote" custom attestation types we see again and again to be more built in - without needing to do CLI/Server development.

Copy link
Contributor

@dangrondahl dangrondahl Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sofusalbertsen have also mentioned Rego/OPA for this. This will perhaps standardize policy definitions, which I see as a good thing. From what I've heard (haven't tried it much myself), Rego has a somewhat steep learning curve.

So it still might make sense to provide common policies (in this format), in some kind of store, for customers to consume?

## Naming convention

* Flows:
* CI part: name your flows like "repo"/"application".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ is not allowed in flow names.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in cyber-dojo, Jon has been using a -ci suffix for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants