Skip to content

Conversation

@guylamar2006
Copy link

No description provided.

@guylamar2006 guylamar2006 changed the title Set universal cmake policy to fix nix build break. Set universal CMP0167 cmake policy to fix nix build break. Mar 12, 2025
@ilya-fedin
Copy link
Contributor

Can you explain why is this needed?

@ilya-fedin
Copy link
Contributor

@ilya-fedin
Copy link
Contributor

But looking at its description I'm not sure there's any sense to set it when you can just add CONFIG argument to find_package?

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Mar 12, 2025

Or maybe even do like OpenAL (try both module and config)

find_package(OpenAL)
if (OPENAL_FOUND)
target_include_directories(external_openal SYSTEM INTERFACE ${OPENAL_INCLUDE_DIR})
target_link_libraries(external_openal INTERFACE ${OPENAL_LIBRARY})
return()
endif()
find_package(OpenAL REQUIRED CONFIG)
target_link_libraries(external_openal INTERFACE OpenAL::OpenAL)
return()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants