feat: add istio virtualservice reconciliation to controller #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
added
area/controller
google-oss-prow
bot
requested review from
andyatmiami,
kimwnasptd and
thesuperzapper
harshad16
changed the title
harshad16
force-pushed
the
virtualservice
branch
2 times, most recently
from
4dcf94e to
50b6026
Compare
Member
|
/ok-to-test |
harshad16
force-pushed
the
virtualservice
branch
from
50b6026 to
a39f413
Compare
harshad16
force-pushed
the
virtualservice
branch
from
a39f413 to
7d737a2
Compare
google-oss-prow
bot
added
area/backend
2 tasks
harshad16
force-pushed
the
virtualservice
branch
from
7d737a2 to
7992330
Compare
harshad16
force-pushed
the
virtualservice
branch
from
7992330 to
b2571d9
Compare
harshad16
changed the title
harshad16
force-pushed
the
virtualservice
branch
from
71d4bc7 to
ea61097
Compare
thesuperzapper
requested changes
Oct 30, 2025
workspaces/controller/config/components/common/kustomization.yaml
Outdated
Show resolved
Hide resolved
workspaces/controller/config/default/components/istio/kustomization.yaml
Show resolved
Hide resolved
workspaces/controller/config/components/istio/kustomization.yaml
Outdated
Show resolved
Hide resolved
workspaces/controller/config/components/istio/kustomization.yaml
Outdated
Show resolved
Hide resolved
workspaces/controller/internal/controller/workspace_controller.go
Outdated
Show resolved
Hide resolved
- Update the helper func with CopyDeepVirtualService - set istio env var as config across controller - make controller manifest consistent with frontend/backend - fix the configmap name in manager_istio_patch.yaml Signed-off-by: Harshad Reddy Nalla <[email protected]>
Signed-off-by: Harshad Reddy Nalla <[email protected]>
Signed-off-by: Harshad Reddy Nalla <[email protected]>
harshad16
force-pushed
the
virtualservice
branch
from
ea61097 to
9f071ad
Compare
Signed-off-by: Harshad Reddy Nalla <[email protected]>
Signed-off-by: Harshad Reddy Nalla <[email protected]>
Signed-off-by: Harshad Reddy Nalla <[email protected]>
Signed-off-by: Harshad Reddy Nalla <[email protected]>
Author
|
All the changes are made and ready for review |
workspaces/controller/internal/controller/workspace_controller.go
Outdated
Show resolved
Hide resolved
workspaces/controller/internal/controller/workspace_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Harshad Reddy Nalla <[email protected]>
thesuperzapper
changed the title
Member
|
@harshad16 amazing work after all this back and forward, this is critical for the future of notebook 2.0, and to get it shipped! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #37
follow-up: #42
Descriptions:
The PR allow controller to connect each workspace with an endpoint that is reachable under the istio mesh.
This virtualservice follow the pattern of unqiue name, so it doesnt collide with notebook v1, if running in the same cluster parallely.
Setup:
The setup require to set the istio deployment in places.
for initial setup:
deploy istio using from kubeflow manifest repo
After deployment of istio, deploy the controller with the image from PR content
make deploy IMG=quay.io/harshad16/nbcv2:controller-istio2kubectl apply -k config/samples/Port forward the istio ingress:
Open the browser, and goto:
localhost:8080//workspace/<namespace>/<workspace-name>/jupyterlab/labCRD change with port in podtemplate:
#507
Following changes are brought by the PR:
demo:
Screencast from 2025-07-28 16-43-01.webm