Skip to content

Conversation

@thaorell
Copy link

closes: #232

Before
Screenshot 2025-10-14 at 10 20 30 AM

After
Screenshot 2025-10-24 at 6 03 51 PM

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Oct 24, 2025
@google-oss-prow google-oss-prow bot added the area/frontend area - related to frontend components label Oct 24, 2025
@google-oss-prow google-oss-prow bot requested review from ederign and paulovmr October 24, 2025 22:05
@google-oss-prow google-oss-prow bot added size/XS area/v2 area - version - kubeflow notebooks v2 labels Oct 24, 2025
@thaorell
Copy link
Author

thaorell commented Oct 30, 2025

@caponetto
Copy link

/lgtm

@paulovmr
Copy link

/ok-to-test

Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thaorell - just one more nit below otherwise LGTM 🚀

Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, thanks @thaorell !

@ederign
Copy link
Member

ederign commented Nov 6, 2025

/approve
/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 07ee02f into kubeflow:notebooks-v2 Nov 6, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/S

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants