Skip to content

Conversation

@monotek
Copy link

@monotek monotek commented Oct 27, 2025

What:

  • Add labels to statefulset created by notebook controller
  • Same labels as for the pods are used

Why:

  • It's best practice to have labels on all resources
  • Be able to exclude statefulset from certain cluster policies (kyverno, opa) by label

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the area/controller area - related to controller components label Oct 27, 2025
@google-oss-prow google-oss-prow bot added area/v1 area - version - kubeflow notebooks v1 size/XS labels Oct 27, 2025
@monotek monotek changed the title add labels to notebook statefulset feat: add labels to notebook statefulset Oct 27, 2025
@kimwnasptd
Copy link
Member

kimwnasptd commented Oct 30, 2025

Thank you for the PR @monotek! For now we are in the process of having a first release for Notebooks V1.

Once this is out of the way we'll go to reviewing other PRs for V1. Although it's a bit under discussion on what further features/fixes we will be having on the V1 branch, and its support window, considering that there are significant efforts to finalise the V2 release.

@monotek
Copy link
Author

monotek commented Nov 3, 2025

Thanks for the update :)
Just let me know if I should add this PR to v2 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller area - related to controller components area/v1 area - version - kubeflow notebooks v1 size/XS

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants