Skip to content

Conversation

@asaadbalum
Copy link

@asaadbalum asaadbalum commented Nov 2, 2025

This PR updates all Go module paths from github.com/kubeflow/kubeflow to github.com/kubeflow/notebooks as part of the repository migration.

Changes Made

1. Updated Module Declarations (3 files)

  • components/notebook-controller/go.mod
  • components/tensorboard-controller/go.mod
  • components/pvcviewer-controller/go.mod
    Note: components/common/go.mod was intentionally NOT updated - it will be updated in a separate PR.

Changed module paths from:

module github.com/kubeflow/kubeflow/components/<component>

to:

module github.com/kubeflow/notebooks/components/<component>

2. Updated Import Statements (16 Go source files)

All internal import statements (imports within the same component) now reference github.com/kubeflow/notebooks to match the new module declarations.

External imports to components/common remain as github.com/kubeflow/kubeflow/components/common since that module hasn't migrated yet.

Files updated:

  • components/notebook-controller/main.go and controllers
  • components/notebook-controller/api/v1/*.go and v1alpha1/*.go
  • components/tensorboard-controller/main.go and controllers
  • components/pvcviewer-controller/main.go and controllers

Testing

All components compile successfully

cd components/notebook-controller && go build     # ✅ Pass
cd components/tensorboard-controller && go build  # ✅ Pass
cd components/pvcviewer-controller && go build    # ✅ Pass

Files Changed

  • 3 go.mod files
  • 16 *.go source files

Acceptance Criteria from #699

  • All go.mod files reference kubeflow/notebooks instead of kubeflow/kubeflow
  • All components compile successfully
  • CI pipelines remain green (will be verified after PR)

Closes #699

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the area/controller area - related to controller components label Nov 2, 2025
@google-oss-prow google-oss-prow bot requested a review from kimwnasptd November 2, 2025 09:52
@google-oss-prow google-oss-prow bot added the area/v1 area - version - kubeflow notebooks v1 label Nov 2, 2025
…books

- Updated module declarations in 3 go.mod files (notebook-controller, tensorboard-controller, pvcviewer-controller)
- Updated all internal import statements in Go source files to match new module paths
- Kept common module and external references to common unchanged (will be updated in separate PR)
- Verified all components compile successfully

Fixes kubeflow#699

Signed-off-by: Asaad Balum <[email protected]>
@asaadbalum asaadbalum force-pushed the 699/update-go-module-paths branch from 86e73b1 to ad642c1 Compare November 2, 2025 10:36
@asaadbalum asaadbalum changed the title Update Go module paths from kubeflow/kubeflow to kubeflow/notebooks chore: Update Go module paths from kubeflow/kubeflow to kubeflow/notebooks Nov 2, 2025
@andyatmiami
Copy link
Contributor

/hold

we will want to rebase this after #702 is merged.

Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general - I am comfortable with the changes included in this PR. I am just holding off on the lgtm until after we rebase this once #702 is merged so the CI workflows can do their magic .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller area - related to controller components area/v1 area - version - kubeflow notebooks v1 do-not-merge/hold size/M

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants