Skip to content

Conversation

@jayzalani
Copy link

Description of your changes:
Updated the Python version from 3.9 to 3.10 as mentioned Python will drop support for 3.9 on 1st October 2025, this PR specifically updated version of python on area/sdk. Reference for this update is taken from this PR#11159

** suggestion **
Kindly check for typing-extensions>=3.7.4,<5; python_version<"3.9 Here version is not updated as in next versions of python it is not needed, as this PR is more dedicated to area/adk, more construct solution would be to update it to this typing-extensions>=3.7.4,<5.

Requirements in sdk/python/requirements-dev.txt are quite old suggestion is to update them to newer versions.
eg file
absl-py>=2.0.0 docformatter>=1.7.0 docker>=7.0.0 isort>=5.13.0 mypy>=1.8.0 pip-tools>=7.0.0 pre-commit>=3.6.0 pycln>=2.4.0 pylint>=3.0.0 pytest>=8.0.0 pytest-cov>=5.0.0 pytest-xdist>=3.5.0 types-protobuf>=4.24.0 types-PyYAML>=6.0.12 types-requests>=2.31.0 types-tabulate>=0.9.0 yapf>=0.40.0

Checklist:

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign james-jwu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @jayzalani. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@vikas-saxena02
Copy link

@jayzalani you need to sign off your commits

@jayzalani
Copy link
Author

@vikas-saxena02, Yeah, I noticed that immediately when made PR,

@hbelmiro
Copy link
Contributor

hbelmiro commented Aug 1, 2025

/ok-to-test

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

Approvals successfully granted for pending runs.

@zazulam
Copy link
Collaborator

zazulam commented Aug 1, 2025

@jayzalani can you update the python versions in the github workflows to python 3.10 as well for the CI?

@jayzalani
Copy link
Author

Yeah sure! @zazulam

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Aug 4, 2025
@hbelmiro
Copy link
Contributor

hbelmiro commented Aug 4, 2025

/ok-to-test

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

Approvals successfully granted for pending runs.

@hbelmiro
Copy link
Contributor

hbelmiro commented Aug 4, 2025

@jayzalani can you please sign off your commits?

Also, the CI is red.

@zazulam
Copy link
Collaborator

zazulam commented Aug 5, 2025

@jayzalani you may have to rebase with master as well since there was a release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants