-
Couldn't load subscription status.
- Fork 1.8k
chore(sdk): Drop support for Python 3.9, discuss 3.10 solved issue #11922 #12095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @jayzalani. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
|
@jayzalani you need to sign off your commits |
|
@vikas-saxena02, Yeah, I noticed that immediately when made PR, |
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
@jayzalani can you update the python versions in the github workflows to python 3.10 as well for the CI? |
|
Yeah sure! @zazulam |
Signed-off-by: jayzalani <[email protected]>
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
@jayzalani can you please sign off your commits? Also, the CI is red. |
|
@jayzalani you may have to rebase with master as well since there was a release today. |
Description of your changes:
Updated the Python version from 3.9 to 3.10 as mentioned Python will drop support for 3.9 on 1st October 2025, this PR specifically updated version of python on area/sdk. Reference for this update is taken from this PR#11159
** suggestion **
Kindly check for
typing-extensions>=3.7.4,<5; python_version<"3.9Here version is not updated as in next versions of python it is not needed, as this PR is more dedicated to area/adk, more construct solution would be to update it to thistyping-extensions>=3.7.4,<5.Requirements in
sdk/python/requirements-dev.txtare quite old suggestion is to update them to newer versions.eg file
absl-py>=2.0.0 docformatter>=1.7.0 docker>=7.0.0 isort>=5.13.0 mypy>=1.8.0 pip-tools>=7.0.0 pre-commit>=3.6.0 pycln>=2.4.0 pylint>=3.0.0 pytest>=8.0.0 pytest-cov>=5.0.0 pytest-xdist>=3.5.0 types-protobuf>=4.24.0 types-PyYAML>=6.0.12 types-requests>=2.31.0 types-tabulate>=0.9.0 yapf>=0.40.0Checklist: