Remove kfp dependency executor #12172

aniketpati1121 · 2025-08-22T12:12:43Z

This PR removes the KFP dependency executor and related checks from the Kubeflow Pipelines SDK. The _KFP_RUNTIME check in kfp/init.py has been removed, and necessary updates have been applied to ensure compatibility.

fixes #12090

google-oss-prow · 2025-08-22T12:12:53Z

Hi @aniketpati1121. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

github-actions · 2025-08-22T12:13:04Z

🚫 This command cannot be processed. Only organization members or owners can use the commands.

aniketpati1121 · 2025-09-01T10:39:10Z

Hi all,
This PR is ready for review.
All checks have passed successfully.
Looking forward to your feedback. Thanks!

zazulam · 2025-09-09T12:46:41Z

/ok-to-test

github-actions · 2025-09-09T12:47:13Z

Approvals successfully granted for pending runs.

google-oss-prow · 2025-09-12T11:15:49Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

sdk/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: aniketpatil <[email protected]>

Signed-off-by: Aniket Patil <[email protected]>

aniketpati1121 · 2025-09-15T04:49:24Z

Hi @kubeflow/owners,

This PR removes the KFP dependency executor and related checks. All conflicts have been resolved, rebase is done, and all CI checks (CI Check, DCO) have passed successfully. Could you please review and provide /lgtm and /approve so that it can be merged?

Thanks for your time and support!

zazulam

Hey @aniketpati1121! Thank you for taking on the issue, the scope for that issue was more along the lines of removing the need of the kfp dependency within the dsl.executor. In turn, trying to isolate the executor. I may end up closing that issue for a more refined one.

zazulam · 2025-09-16T14:17:03Z

sdk/python/test_kfp_version.py

@@ -0,0 +1,3 @@
+import kfp
+


I believe this file can be removed.

zazulam · 2025-09-16T14:17:40Z

sdk/python/kfp/dsl/v1_modelbase.py

-from typing import (Any, cast, Dict, get_type_hints, List, Mapping,
-                    MutableMapping, MutableSequence, Sequence, Type, TypeVar,
-                    Union)
+from typing import Any, cast, Dict, get_type_hints, List, Mapping, MutableMapping, MutableSequence, Sequence, Type, TypeVar, Union


I think the linter might not like this change.

sdk/python/kfp/dsl/structures.py
chore(sdk): cleanup imports in component_factory

Grouped stdlib, third-party, and local imports

Converted long imports to parentheses for readability

Removed unused import kfp

zazulam · 2025-09-16T14:17:54Z

sdk/python/kfp/dsl/component_factory.py

 import textwrap
-from typing import (Any, Callable, Dict, List, Mapping, Optional, Tuple, Type,
-                    Union)
+from typing import Any, Callable, Dict, List, Mapping, Optional, Tuple, Type, Union


Linter might not like.

zazulam · 2025-09-16T14:18:12Z

sdk/python/kfp/compiler/pipeline_spec_builder.py

 import typing
-from typing import (Any, DefaultDict, Dict, List, Mapping, Optional, Tuple,
-                    Union)
+from typing import Any, DefaultDict, Dict, List, Mapping, Optional, Tuple, Union


Linter might not like

zazulam · 2025-09-16T14:19:47Z

sdk/python/kfp/cli/cli.py

-@click.version_option(version=kfp.__version__, message='%(prog)s %(version)s')
+@click.version_option(version=_version.__version__, message='%(prog)s %(version)s')


I don't think this change is needed.

zazulam · 2025-09-16T14:20:45Z

sdk/python/kfp/__init__.py

-    __version__ = 'dev'
+    __version__ = "0.0.0+dev"


Not sure if this is needed.

Signed-off-by: Aniket Patil <[email protected]>

aniketpati1121 · 2025-09-17T05:49:23Z

Hi @zazulam,

Thanks for the feedback!

The test file (test_kfp_version.py) was only used for local testing and is now removed.
Duplicate imports and unused code were cleaned up for linter safety.
Let me know if you have any further suggestions for improvements.
Thanks again for your time and guidance!

google-oss-prow bot requested review from DharmitD and zazulam August 22, 2025 12:12

google-oss-prow bot added needs-ok-to-test size/M labels Aug 22, 2025

aniketpati1121 force-pushed the remove-kfp-dependency-executor branch 2 times, most recently from 5bb7118 to 122ca21 Compare August 22, 2025 18:07

aniketpati1121 force-pushed the remove-kfp-dependency-executor branch from 122ca21 to c0addc3 Compare September 1, 2025 06:50

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Sep 9, 2025

aniketpati1121 force-pushed the remove-kfp-dependency-executor branch 2 times, most recently from fcb0f6c to 6ec4cb4 Compare September 12, 2025 11:15

aniketpatil and others added 3 commits September 15, 2025 10:05

chore: remove _KFP_RUNTIME check from kfp/__init__.py

dbc4c23

Signed-off-by: aniketpatil <[email protected]>

Remove KFP dependency executor and related fixes

6f3fa76

Signed-off-by: aniketpatil <[email protected]>

style: fix imports with isort

78220c7

Signed-off-by: Aniket Patil <[email protected]>

aniketpati1121 force-pushed the remove-kfp-dependency-executor branch from 6ec4cb4 to 78220c7 Compare September 15, 2025 04:42

zazulam reviewed Sep 16, 2025

View reviewed changes

google-oss-prow bot added size/L and removed size/M labels Sep 17, 2025

aniketpati1121 force-pushed the remove-kfp-dependency-executor branch from 3667cdc to 095de4e Compare September 17, 2025 05:31

style: clean imports, remove unused imports, linter-safe

b202677

Signed-off-by: Aniket Patil <[email protected]>

aniketpati1121 force-pushed the remove-kfp-dependency-executor branch from 095de4e to b202677 Compare September 17, 2025 05:45

Merge branch 'master' into remove-kfp-dependency-executor

47cb48d

aniketpati1121 closed this Sep 30, 2025

aniketpati1121 deleted the remove-kfp-dependency-executor branch September 30, 2025 19:48

		@click.version_option(version=kfp.__version__, message='%(prog)s %(version)s')
		@click.version_option(version=_version.__version__, message='%(prog)s %(version)s')

Uh oh!

Remove kfp dependency executor #12172

Remove kfp dependency executor #12172

Uh oh!

Conversation

aniketpati1121 commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-oss-prow bot commented Aug 22, 2025

Uh oh!

github-actions bot commented Aug 22, 2025

Uh oh!

aniketpati1121 commented Sep 1, 2025

Uh oh!

zazulam commented Sep 9, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

google-oss-prow bot commented Sep 12, 2025

Uh oh!

aniketpati1121 commented Sep 15, 2025

Uh oh!

zazulam left a comment

Choose a reason for hiding this comment

Uh oh!

zazulam Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

zazulam Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

aniketpati1121 Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

zazulam Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

zazulam Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

zazulam Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

zazulam Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

aniketpati1121 commented Sep 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aniketpati1121 commented Aug 22, 2025 •

edited

Loading