Skip to content

Conversation

vikas-saxena02
Copy link

@vikas-saxena02 vikas-saxena02 commented Aug 27, 2025

As part of kubeflow/manifests#2991, we need to fix up kustomize warnings in upstream. This MR is one of the few which will be raised in near future to address it

Checklist:

@google-oss-prow google-oss-prow bot requested review from hbelmiro and mprahl August 27, 2025 11:20
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikas-saxena02
Copy link
Author

/ok-to-test

…p-namespace,kfp-app-name,kfp-app-version,kfp-artifact-bucket-name

Signed-off-by: Vikas Saxena <[email protected]>
Signed-off-by: Vikas Saxena <[email protected]>
This reverts commit 4dddc17.

Signed-off-by: Vikas Saxena <[email protected]>
Signed-off-by: Vikas Saxena <[email protected]>
@vikas-saxena02 vikas-saxena02 force-pushed the fix_kustomize5_warnings branch from 7fe581f to 2ba704c Compare August 27, 2025 12:03
@vikas-saxena02
Copy link
Author

evidence that nothing has chnaged
Screenshot 2025-08-27 at 9 59 55 pm

@juliusvonkohout
Copy link
Member

Just ping me when i shall review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants