-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(backend): Add configuration to conditionally disable shared pipeline resources #12202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(backend): Add configuration to conditionally disable shared pipeline resources #12202
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @krishanbhasin-px. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
d1f2af9
to
b17f453
Compare
/ok-to-test |
@krishanbhasin-px Please rebase your PR |
Approvals successfully granted for pending runs. |
b17f453
to
136f4ea
Compare
Signed-off-by: Krishan Bhasin <[email protected]>
136f4ea
to
0e5f9ce
Compare
@krishanbhasin-px thanks for the pr, could you address the ci failures? feel free to ping me in slack for another look if I miss the re-review |
@HumairAK happily! Can I take this as confirmation that you/the team is happy with the intent of this PR? I wanted to get a confirmation before I put time into preparing it 'properly' |
Description of your changes:
This PR will add a new configuration option for Kubeflow to optionally disable the ability to upload pipelines to the "shared" space (achieved by setting
namespace
toNone
/""
).This config will default to the same behaviour as right now (allowing shared pipelines) so this should not be a breaking change for existing users.
I was curious about the possibility of even doing this which is why I started drafting the code change up front.
I have now opened this PR early to share the idea; if you are open to merging this change I can implement the relevant tests and any other bits that are needed in order to get this in.
I summarised the problem I am trying to solve with this in the CNCF Slack group; I've copied the important bits below:
problem statement
I'm working in an environment where we want to deploy Kubeflow in a multi-tenant way; where I can isolate access to each tenant based on the authorisation of the logged in user.
For example I have a single Kubeflow instance, with 3 tenants that need to use it - "Project A", "Project B", and "Project C".
Alice and Alex work on A, Bob works on B, and Charlie works on C. Users that work on a particular project should not have access to resources for an other project.
To implement this, I have created KubeFlow Profiles for "Proj-A", "Proj-B", and "Proj-C". As the notebook instances within those profiles don't have access controls (and after reading previous threads on this matter), I have also created "child" profiles for each of my users - "Alice-A", "Alex-A", "Bob-B", "Charlie-C". So Alice has access to "Proj-A" and "Alice-A" (and the rest follow similarly)
I had hoped to have each user work in notebooks in their private profiles and, once they have created a pipeline that they think is worth using longer-term, they "publish" it to the project's main profile.
In my testing of this setup I have realised that:
I can't find a way to allow a notebook in profile "Alice-A" to upload/publish a pipeline to "Proj-A"'s private pipeline spaceJulius von Kohout
namespace=None
in theupload
API call), but unfortunately, any profile in the kubeflow instance can access them - I want to avoid this possibility (whether done by accident or otherwise).Checklist: