Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/components/PipelinesDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ const PipelinesDialog: React.FC<PipelinesDialogProps> = (props): JSX.Element | n
<ResourceSelector
{...props}
filterLabel='Filter pipelines'
isV1={true}
listApi={async (...args) => {
if (buildInfo?.apiServerMultiUser && view === NamespacedAndSharedTab.NAMESPACED) {
args.push('NAMESPACE');
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/pages/NewRun.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ export class NewRun extends Page<NewRunProps, NewRunState> {
{...this.props}
title='Choose a pipeline version'
filterLabel='Filter pipeline versions'
isV1={true}
listApi={async (...args) => {
const response = await Apis.pipelineServiceApi.listPipelineVersions(
'PIPELINE',
Expand Down Expand Up @@ -402,6 +403,7 @@ export class NewRun extends Page<NewRunProps, NewRunState> {
{...this.props}
title='Choose an experiment'
filterLabel='Filter experiments'
isV1={true}
listApi={async (
page_token?: string,
page_size?: number,
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/pages/ResourceSelector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export interface ResourceSelectorProps extends RouteComponentProps {
title?: string;
toolbarActionMap?: ToolbarActionMap;
updateDialog: (dialogProps: DialogProps) => void;
isV1?: boolean;
}

interface ResourceSelectorState {
Expand Down Expand Up @@ -79,7 +80,7 @@ class ResourceSelector extends React.Component<ResourceSelectorProps, ResourceSe
{title && <Toolbar actions={toolbarActionMap} breadcrumbs={[]} pageTitle={title} />}

<CustomTable
isCalledByV1={false}
isCalledByV1={!!this.props.isV1}
columns={columns}
rows={rows}
selectedIds={selectedIds}
Expand Down
16 changes: 16 additions & 0 deletions frontend/src/pages/__snapshots__/NewRun.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ exports[`NewRun arriving from pipeline details page indicates that a pipeline is
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -253,6 +254,7 @@ exports[`NewRun arriving from pipeline details page indicates that a pipeline is
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -633,6 +635,7 @@ exports[`NewRun changes the exit button's text if query params indicate this is
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -742,6 +745,7 @@ exports[`NewRun changes the exit button's text if query params indicate this is
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -1122,6 +1126,7 @@ exports[`NewRun changes title and form if the new run will recur, based on the r
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -1231,6 +1236,7 @@ exports[`NewRun changes title and form if the new run will recur, based on the r
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -1629,6 +1635,7 @@ exports[`NewRun changes title and form to default state if the new run is a one-
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -1738,6 +1745,7 @@ exports[`NewRun changes title and form to default state if the new run is a one-
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -2118,6 +2126,7 @@ exports[`NewRun fetches the associated pipeline if one is present in the query p
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -2227,6 +2236,7 @@ exports[`NewRun fetches the associated pipeline if one is present in the query p
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -2605,6 +2615,7 @@ exports[`NewRun renders the new run page 1`] = `
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -2714,6 +2725,7 @@ exports[`NewRun renders the new run page 1`] = `
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -3094,6 +3106,7 @@ exports[`NewRun starting a new recurring run includes additional trigger input f
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -3203,6 +3216,7 @@ exports[`NewRun starting a new recurring run includes additional trigger input f
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -3601,6 +3615,7 @@ exports[`NewRun updates the run's state with the associated experiment if one is
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down Expand Up @@ -3710,6 +3725,7 @@ exports[`NewRun updates the run's state with the associated experiment if one is
}
}
initialSortColumn="created_at"
isV1={true}
listApi={[Function]}
location={
Object {
Expand Down