-
Notifications
You must be signed in to change notification settings - Fork 840
Add debugLogs parameter to helm chart #2624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Coverage DiffThis PR does not change the code coverage |
/hold Holding for release |
/unhold |
59855e1
to
6cec0ab
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Tested manually:
> helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver | grep "v="
- --v=2
- --v=2
- --v=2
- --v=2
- --v=2
- --v=2
- --v=2
- --v=2
--------------------
> helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver --set debugLogs=true | grep "v="
- --v=7
- --v=7
- --v=7
- --v=7
- --v=7
- --v=7
- --v=7
- --v=7
-------------------
> helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver --set debugLogs=true | grep "sdk"
- --aws-sdk-debug-log=true
-------------------
> helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver --set debugLogs=false | grep "sdk"
<blank>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdzraf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
Let customers easily show debug logs of all containers from add-on/helm installation.
How was this change tested?
Does this PR introduce a user-facing change?