Skip to content

Add debugLogs parameter to helm chart #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025

Conversation

AndrewSirenko
Copy link
Contributor

What type of PR is this?

/kind feature

What is this PR about? / Why do we need it?

Let customers easily show debug logs of all containers from add-on/helm installation.

How was this change tested?

❯ helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver | grep "v="
            - --v=2
            - --v=2
            - --v=2
            - --v=2
            - --v=2
            - --v=2
            - --v=2
            - --v=2
❯ helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver --set debugLogs=true | grep "v="
            - --v=7
            - --v=7
            - --v=7
            - --v=7
            - --v=7
            - --v=7
            - --v=7
            - --v=7
❯ helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver --set debugLogs=true | grep "sdk"
            - --aws-sdk-debug-log=true
❯ helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver --set debugLogs=false | grep "sdk"
<NOTHING>

Does this PR introduce a user-facing change?

Add debugLogs helm parameter to turn on maximum verbosity for each EBS CSI Driver container

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 19, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2025
Copy link

Code Coverage Diff

This PR does not change the code coverage

@ElijahQuinones
Copy link
Member

/hold

Holding for release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2025
@ElijahQuinones
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2025
Copy link
Member

@mdzraf mdzraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Tested manually:

> helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver | grep "v="
            - --v=2
            - --v=2
            - --v=2
            - --v=2
            - --v=2
            - --v=2
            - --v=2
            - --v=2
--------------------
> helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver --set debugLogs=true | grep "v="
            - --v=7
            - --v=7
            - --v=7
            - --v=7
            - --v=7
            - --v=7
            - --v=7
            - --v=7
-------------------
> helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver --set debugLogs=true | grep "sdk"
            - --aws-sdk-debug-log=true
-------------------
> helm template aws-ebs-csi-driver ./charts/aws-ebs-csi-driver --set debugLogs=false | grep "sdk"
<blank>
            

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdzraf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0e7d2c9 into kubernetes-sigs:master Aug 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants