Skip to content

🌱chore: Update golangci-lint version to v2.4.0 #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

🌱chore: Update golangci-lint version to v2.4.0 #3318

merged 1 commit into from
Sep 16, 2025
+1 −2

Conversation

dongjiang1989
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2025
@JoelSpeed
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2025
@dongjiang1989 dongjiang1989 mentioned this pull request Sep 12, 2025
Merged
@JoelSpeed
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0ec93d816d87b78632ecee777c8b553293138d41

sbueringer
sbueringer reviewed Sep 12, 2025
View reviewed changes
.golangci.yml Outdated
@@ -180,6 +181,9 @@ linters:
- staticcheck
path: (.+)\.go$
text: (ST1000|QF1008)
- text: "Line contains TODO/BUG/FIXME"
Copy link
Member

@sbueringer sbueringer Sep 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as on the controller-tools PR

Why are we adding a linter and then disabling it? (or is there some part of the linter still active?)

Copy link
Contributor Author

@dongjiang1989 dongjiang1989 Sep 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbueringer

This is some part of the linter still active. Others keywords like NOTE, OPTIMIZE, HACK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the docs I would have thought TODO / BUG / FIXME is default: https://golangci-lint.run/docs/linters/configuration/#godox. Is that not correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I miss it
Added it done.

Copy link
Member

@sbueringer sbueringer Sep 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm not sure if we should block Note/Optimize/Hack. I think notes are actually beneficial and I don't have a problem with optimize/hack (although we have 0 occurences of these)

Also not sure what our opinion is on TODO/BUG/FIXME.

I personally use FIXME only locally and remove them before PR reviews. TODOs are generally kept and merged (apparently). We have no occurences of BUG.

So I personally would only block FIXME. But I'm also fine with keeping it all as is on main and not block anything

@JoelSpeed @alvaroaleman Opinions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbueringer @JoelSpeed
Change it by codereview

Copy link
Member

@sbueringer sbueringer Sep 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for Alvaro's take. In general I would prefer if we would configure the linter to only alert on the cases we want to block. Not configure it for 6 cases and then exclude 4 :)

(I would also not block BUG, I've never sawn anyone adding a "BUG" comment somewhere, so it doesn't seem to make much sense to block it)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any of Note/Hack/Bug/Todo/Fixme are a reason to just block in CI. There may be cases where that is indicative of something left, but I don't think its safe to assume that is always the case and this will likely just make this linter a nuissance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alvaroaleman @sbueringer
Remove godox as default?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2025
@dongjiang1989 dongjiang1989 force-pushed the update-golangci-version branch from 43a90c5 to 36a7035 Compare September 15, 2025 07:08
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 15, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2025
@dongjiang1989 dongjiang1989 force-pushed the update-golangci-version branch from 6f3c20a to 5e2c9ce Compare September 16, 2025 01:18
@dongjiang1989
Copy link
Contributor Author

/test pull-controller-runtime-test

1 similar comment
@dongjiang1989
Copy link
Contributor Author

/test pull-controller-runtime-test

@sbueringer sbueringer removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 16, 2025
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongjiang1989, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 16, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6032c34f8f357235d2d3a73cea06264f56852531

@k8s-ci-robot k8s-ci-robot merged commit feefdb8 into kubernetes-sigs:main Sep 16, 2025
10 checks passed
@dongjiang1989 dongjiang1989 deleted the update-golangci-version branch September 17, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@alvaroaleman alvaroaleman alvaroaleman left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@sbueringer sbueringer

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dongjiang1989 @k8s-ci-robot @JoelSpeed @sbueringer @alvaroaleman