Skip to content

🌱chore: Update golangci-lint version to v2.5.0 #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

🌱chore: Update golangci-lint version to v2.5.0 #3323

merged 1 commit into from
Oct 3, 2025

Conversation

dongjiang1989
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 24, 2025
@dongjiang1989 dongjiang1989 mentioned this pull request Sep 24, 2025
Merged
chrischdi
chrischdi reviewed Sep 24, 2025
View reviewed changes
@chrischdi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2025
sbueringer
sbueringer reviewed Sep 24, 2025
View reviewed changes
examples/crd/pkg/groupversion_info.go Outdated
limitations under the License.
*/

// Package pkg contains utilities for gradually building Schemes,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems a bit off. Looks like this package basically contains the API types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbueringer
Change doc done

JoelSpeed
JoelSpeed reviewed Sep 24, 2025
View reviewed changes
pkg/log/zap/flags.go
limitations under the License.
*/

// Package zap contains helpers for setting up a new logr.Logger instance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another godoc for this package already?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the same in a different file

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 24, 2025
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 09131834b84273899cd517b7c31e918ba3dbc50a

@dongjiang1989 @chrischdi
update golangci-lint to v2.5.0
114e29c 
Signed-off-by: dongjiang <[email protected]>

update golangci-lint to v2.5.0

Signed-off-by: dongjiang <[email protected]>

Update examples/tokenreview/tokenreview.go

Update pkg/reconcile/reconcile.go

Co-Authored-By: Christian Schlotter <[email protected]>
@dongjiang1989 dongjiang1989 force-pushed the upgrade-golangci-lint-version branch from 80b6382 to 114e29c Compare September 25, 2025 01:56
@dongjiang1989
Copy link
Contributor Author

@sbueringer merge-method-squash done

@sbueringer
Copy link
Member

/lgtm
/assign @JoelSpeed

@sbueringer
Copy link
Member

Thank you!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongjiang1989, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 655fb2c into kubernetes-sigs:main Oct 3, 2025
9 checks passed
@dongjiang1989 dongjiang1989 deleted the upgrade-golangci-lint-version branch October 13, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@joelanford joelanford Awaiting requested review from joelanford

@vincepri vincepri Awaiting requested review from vincepri

+2 more reviewers

@chrischdi chrischdi chrischdi left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sbueringer sbueringer

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dongjiang1989 @k8s-ci-robot @chrischdi @sbueringer @JoelSpeed