Skip to content

pkg/common/utils.go: update regionalLocationFmt for Europe with 10+ regions #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −2
Open

pkg/common/utils.go: update regionalLocationFmt for Europe with 10+ regions #2117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40fd21c
pkg/common/utils.go: update regionalLocationFmt for Europe with 10+ r…
JordanP Jun 26, 2025
b8ca4f6
Add unit test
JordanP Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/common/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const (
// Example: us
multiRegionalLocationFmt = "^[a-z]+$"
// Example: us-east1
regionalLocationFmt = "^[a-z]+-[a-z]+[0-9]$"
regionalLocationFmt = "^[a-z]+-[a-z]+[0-9]{1,2}$"

// Full or partial URL of the machine type resource, in the format:
// zones/zone/machineTypes/machine-type
Expand Down
8 changes: 7 additions & 1 deletion pkg/common/utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,10 +804,16 @@ func TestSnapshotStorageLocations(t *testing.T) {
[]string{"us-east1"},
false,
},
{
"valid region in large continent",
"europe-west12",
[]string{"europe-west12"},
false,
},
{
// Zones are not valid bucket/snapshot locations.
"single zone",
"us-east1a",
"us-east1-a",
[]string{},
true,
},
Expand Down