Skip to content

backend: Refactor createHeadlampHandler to reduce complexity #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

backend: Refactor createHeadlampHandler to reduce complexity #3665

wants to merge 4 commits into from

Conversation

illume
Copy link
Contributor

@illume illume commented Jul 21, 2025 •
edited
Loading

This doesn't change any logic, it just extracts the first few functions from createHeadlampHandler.

  • backend: cmd: Extract logStartupInfo from createHeadlampHandler
  • backend: kubeconfig: Export ShouldBeSkippedFunc
  • backend: cmd: Extract setupPluginHandler from createHeadlampHandler
  • backend: cmd: Extract setupInClusterContext from createHeadlampHandler

Based on this PR(but only does a few functions)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2025
@k8s-ci-robot k8s-ci-robot requested review from sniok and yolossn July 21, 2025 12:39
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2025
@illume illume changed the title backend: Refactor createHeadlampHandler to reduce complexity #3390 backend: Refactor createHeadlampHandler to reduce complexity Jul 21, 2025
@illume illume force-pushed the createHeadlampHandler-1 branch from f783240 to f339132 Compare August 26, 2025 17:57
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2025
skoeva
skoeva reviewed Sep 15, 2025
View reviewed changes
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to get this through, could you rebase against main?

@illume illume marked this pull request as draft September 26, 2025 10:45
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2025
@illume illume mentioned this pull request Sep 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoeva skoeva skoeva left review comments

@sniok sniok Awaiting requested review from sniok

@yolossn yolossn Awaiting requested review from yolossn

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@illume @k8s-ci-robot @skoeva @SinghaAnirban005