Skip to content

Add support for running mcp servers from desktop app #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add support for running mcp servers from desktop app #3888

wants to merge 4 commits into from

Conversation

ashu8912
Copy link
Member

@ashu8912 ashu8912 commented Sep 8, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashu8912
Once this PR has been reviewed and has the lgtm label, please assign joaquimrocha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2025
@ashu8912 ashu8912 marked this pull request as draft September 8, 2025 17:31
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 8, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2025
@illume illume added this to the v0.37.0 milestone Sep 26, 2025
joaquimrocha
joaquimrocha requested changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app laywer always has to double check for potentially destructive actions or portentially disruptive ones, like setting up MCP servers.

app/electron/mcp-client.ts
});

// Handle MCP tool execution
ipcMain.handle('mcp-execute-tool', async (event, { toolName, args, toolCallId }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check if the tool is enabled. The source of truth for this needs to be on the app layer side, and the user needs to confirm it the first time it's configured.

app/electron/mcp-client.ts
});

// Handle MCP configuration updates
ipcMain.handle('mcp-update-config', async (event, mcpConfig: MCPConfig) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to confirm with the user that the configuration is what's desired, unless we're just disabling an MCP server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquimrocha joaquimrocha joaquimrocha requested changes

@illume illume Awaiting requested review from illume

@yolossn yolossn Awaiting requested review from yolossn

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.37.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ashu8912 @k8s-ci-robot @joaquimrocha @illume