-
Notifications
You must be signed in to change notification settings - Fork 445
Allow running the whole project using npm #3953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joaquimrocha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces npm-based build and development workflows for the Headlamp project, replacing the existing make-based approach with standardized npm scripts. The changes enable developers to build, test, and run the entire project using only npm commands.
- Adds a root-level package.json with comprehensive npm scripts for all project components
- Updates build scripts and configurations to use npm commands instead of make
- Renames package names across workspaces to follow consistent naming conventions
Reviewed Changes
Copilot reviewed 8 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
package.json | Adds root package.json with workspaces configuration and comprehensive npm scripts for building, testing, and running all project components |
frontend/vite.config.ts | Updates monaco-editor path to work with workspace structure |
frontend/package.json | Renames package from "headlamp" to "headlamp-frontend" for consistency |
e2e-tests/package.json | Renames package from "e2e-tests" to "headlamp-e2e-tests" for consistency |
app/scripts/start.js | Replaces make commands with npm equivalents for backend building and starting |
app/scripts/build-backend.js | Replaces make backend command with npm run backend:build |
app/package.json | Adds electronVersion and semver dependency |
app/e2e-tests/package.json | Renames package from "e2e-tests" to "headlamp-app-e2e-tests" for consistency |
Files not reviewed (3)
- app/e2e-tests/package-lock.json: Language not supported
- e2e-tests/package-lock.json: Language not supported
- load-tests/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
91f7569
to
c4c90a5
Compare
816917c
to
ce80cbf
Compare
13673bf
to
f0c568c
Compare
Signed-off-by: Joaquim Rocha <[email protected]>
Signed-off-by: Joaquim Rocha <[email protected]>
Signed-off-by: Joaquim Rocha <[email protected]>
Signed-off-by: Joaquim Rocha <[email protected]>
Signed-off-by: Joaquim Rocha <[email protected]>
Signed-off-by: Joaquim Rocha <[email protected]>
Signed-off-by: Joaquim Rocha <[email protected]>
f0c568c
to
fc83a23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems one of the CI jobs is failing still, so I put it in draft mode.
When it's working for you, I think breaking this up into separate PRs would be good. To reduce the size and risk. Probably a bunch of your commits are separate enough to do this?
Can you please confirm which platforms you've tested on in the PR?
Summary
This PR allows building and running Headlamp by using npm alone, instead of having to install and use make for some things and using npm for others.
Steps to Test
npm run
Still Missing