Skip to content

Conversation

illume
Copy link
Contributor

@illume illume commented Oct 3, 2025

Some small performance improvements for app loading.

  • app: Fix to not use sync when getting bundledPlugins dir
  • app: Fix isWSL check to be async
  • app: Fix isWSL to do a cheap platform check first
  • app: Make loadZoomFactor async and avoid modifying zoom if not needed
  • app: Fix build manifest loading to be async

Testing

  • Zoom persistence still works (change app zoom, restart app)
  • Build app and check that plugin catalog is still there

Benchmarks

This was timed with video, excluding the first load. I expect this to work faster with a cold cache... because a lot of these changes are avoiding blocking when there's IO.

  • Surface book 3 WSL compiled app(linux_unpacked), to see clusters: 6.5 seconds4.0 seconds1.6x faster
  • Surface book 3 Windows compiled app, to see clusters: 4.7 seconds3.8 seconds1.2x faster
  • Macbook Air M4 compiled app, to see clusters: 1.5 seconds1.6 seconds1.1x slower

For mac the initial window and frontend loads faster... but initially shows no cluster data, then the cluster data comes in. So I think there's a separate fix needed in the frontend.

illume added 5 commits October 3, 2025 17:25
This pauses the main thread to wait for it to finish.
Before it would block the main thread.
This is faster on non-linux platforms.
Also remove a filecheck that isn't needed.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2025
@illume illume changed the title app: Load performance improvements app: Small load time performance improvements Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. performance size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants