-
Notifications
You must be signed in to change notification settings - Fork 81
add ability to read input file from stdin #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jpiper The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @jpiper. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm Thanks! |
New changes are detected. LGTM label has been removed. |
// Stdin content is stored in memory after the first read to allow multiple calls. | ||
func readFileOrStdin(filename string) ([]byte, error) { | ||
if filename == "-" { | ||
stdinOnce.Do(func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really a big deal, but probably you could simply check if the len of stdIn is > 0 :)
but lgtm
@LiorLieberman leaving the final review for you :) |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows the tool to read input from
stdin
by using the special filename-
(like kubectl does)Does this PR introduce a user-facing change?: