feat: Detect no matching resources #5917

adoramshoval · 2025-05-23T20:45:24Z

This PR aims to resolve the rotten issue no. #4379 .
As #4715 has rotten as well, this PR is continuing the contributor (@laxmikantbpandhare ) work maintaining the already existing commits.

This PR adds the enforcement for resources selectors not matching any resources at all by throwing an error if no resource has been selected.
A new option has been added, allowNoTargetMatch, allowing to avoid this error, which will cause a warning to be printed and resources to rendered if no further error is encountered.

The Options attribute has been replaced from a map[string]bool to a new type under the api directory named PatchArgs. This will provide a better documentation and will help to avoid typing errors.

NOTE: The changes done in this PR have been requested in the PR mentioned above by @annasong20 .

k8s-ci-robot · 2025-05-23T20:45:27Z

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

linux-foundation-easycla · 2025-05-23T20:45:29Z

The committers listed above are authorized under a signed CLA.

✅ login: adoramshoval / name: Adoram Shoval (f329f91)
✅ login: laxmikantbpandhare / name: Laxmikant Bhaskar Pandhare (a4d61b8, 2f127dd)

k8s-ci-robot · 2025-05-23T20:45:34Z

Welcome @adoramshoval!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-05-23T20:45:34Z

Hi @adoramshoval. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stormqueen1990

Hello there, @adoramshoval! Thanks for your contribution.

It's a good idea to refactor the code to use an object type instead of a map for patch options. Could we perhaps have that split out in a separate PR (with its tests), as it would result in a smaller change set to be reviewed for both PRs?

I also have a question: it looks like the new option allowNoTargetMatch is false by default. That would amount to a breaking change in the current kustomize flow, as current kustomizations with no matching resources do not fail to apply, but would start failing once this is merged. Could you please confirm that would be the case?

adoramshoval · 2025-06-13T08:41:37Z

Hi @stormqueen1990 , thanks for your reply.

It's a good idea to refactor the code to use an object type instead of a map for patch options. Could we perhaps have that split out in a separate PR (with its tests), as it would result in a smaller change set to be reviewed for both PRs?

That is correct, thanks, I will work on that.

I also have a question: it looks like the new option allowNoTargetMatch is false by default. That would amount to a breaking change in the current kustomize flow, as current kustomizations with no matching resources do not fail to apply, but would start failing once this is merged. Could you please confirm that would be the case?

Yes, that is the case. Is there a certain work flow I should go through in case of a breaking change?

adoramshoval · 2025-06-14T09:01:15Z

Hi @stormqueen1990 ,
I have created another PR (#5930 ) which contains only the addition of the PatchArgs API type as requested.
This PR was marked as draft and it is based on the other PR including the same commit.
I hope I did everything as you expected, let me know if anything is wrong and I'll fix it.

stormqueen1990 · 2025-06-15T14:37:26Z

Yes, that is the case. Is there a certain work flow I should go through in case of a breaking change?

Hi there, @adoramshoval!

In this case, we'll need some input from the current maintainers.
@koba1t and @varshaprasad96, could you please confirm whether this change requires extra steps due to being a breaking one?

stormqueen1990 · 2025-06-15T14:37:50Z

Hi @stormqueen1990 , I have created another PR (#5930 ) which contains only the addition of the PatchArgs API type as requested. This PR was marked as draft and it is based on the other PR including the same commit. I hope I did everything as you expected, let me know if anything is wrong and I'll fix it.

Thank you very much! I'll take a look at the new PR soon.

koba1t · 2025-06-16T01:00:55Z

/ok-to-test

adoramshoval · 2025-06-19T10:35:28Z

/ok-to-test

Hi @koba1t , I have fixed the errors. Is it possible to re-run the tests?

adoramshoval · 2025-06-26T16:01:28Z

@koba1t , @stormqueen1990 allow me some time while I make some changes based on #5930 .

koba1t · 2025-08-12T10:55:06Z

hi @adoramshoval
I merged #5930, Could you rebase master?

Rebase laxmikantbpandhare commits on top of master

resolved conflicts

…nsformer This commit makes use of the new PatchArgs type and the new Patch option `allowNoTargetMatch`. This option, if true, allows rendering kustomization even if no resource is matched against the given target, while printing a warning to stderr. By default this option is set to false meaning that if no resource is matched against the given target an error is raised. This commit includes the extra tests to test this new feature.

k8s-ci-robot · 2025-08-12T15:01:24Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adoramshoval
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adoramshoval · 2025-08-12T15:06:09Z

hi @adoramshoval I merged #5930, Could you rebase master?

Hi @koba1t , thanks a lot!
I have now finished rebasing master with the changes introduced in the mentioned PR.
I will remove the Draft label from the PR name.

Please let me know if there is anything else I am missing.

adoramshoval · 2025-08-18T09:39:08Z

@stormqueen1990 , @koba1t Could you go over this again and let me know?

stormqueen1990

Hi there, @adoramshoval! Sorry for the delay in reviewing this one.

I left some comments below, please let me know if you have any questions!

stormqueen1990 · 2025-08-23T18:41:53Z

api/types/patch_test.go

-					AllowNameChange: true,
-					AllowKindChange: true,
+					AllowKindChange:    true,
+					AllowNoTargetMatch: true,


This is changing an existing test. Perhaps it would be better to keep it as-is, making only the necessary changes to pass with the current API changes, and add a new test to cover the new feature?

I'm also a bit confused about the removal of line 156.

Oh my bad, I thought it wouldn't make a difference if I change a bit the test.
I'll revert this change.

stormqueen1990 · 2025-08-23T18:43:28Z

plugin/builtin/patchjson6902transformer/PatchJson6902Transformer.go

Could we include some tests for this change?

I have added a test for the change here: https://github.com/kubernetes-sigs/kustomize/pull/5917/files#diff-08aa260c0029be90fe08448a134735f879c3aec100f88c5b7275090c0a84228dR1276

Should it be somewhere else?

stormqueen1990 · 2025-08-23T18:44:04Z

plugin/builtin/patchtransformer/PatchTransformer.go

Similar to plugin/builtin/patchjson6902transformer/PatchJson6902Transformer.go, could we include some tests to ensure things work as intended?

Similar to the above, I have included the tests under api/krusty/extendedpatch_test.go. Should I place them anywhere else?

adoramshoval

Hi @stormqueen1990 , thanks a lot for your review! Answered your comments.

adoramshoval · 2025-08-24T20:13:03Z

plugin/builtin/patchjson6902transformer/PatchJson6902Transformer.go

I have added a test for the change here: https://github.com/kubernetes-sigs/kustomize/pull/5917/files#diff-08aa260c0029be90fe08448a134735f879c3aec100f88c5b7275090c0a84228dR1276

Should it be somewhere else?

adoramshoval · 2025-08-24T20:14:19Z

plugin/builtin/patchtransformer/PatchTransformer.go

Similar to the above, I have included the tests under api/krusty/extendedpatch_test.go. Should I place them anywhere else?

adoramshoval · 2025-08-24T20:19:51Z

api/types/patch_test.go

-					AllowNameChange: true,
-					AllowKindChange: true,
+					AllowKindChange:    true,
+					AllowNoTargetMatch: true,


Oh my bad, I thought it wouldn't make a difference if I change a bit the test.
I'll revert this change.

adoramshoval · 2025-09-24T08:43:32Z

Hi @stormqueen1990 , its been a while, could you give me the clarifications needed in order to continue with this PR?

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 23, 2025

k8s-ci-robot requested review from ncapps and stormqueen1990 May 23, 2025 20:45

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 23, 2025

adoramshoval force-pushed the detect-no-matching-resources branch from d88131f to 015d04b Compare May 23, 2025 20:57

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 23, 2025

This was referenced Jun 7, 2025

Modified code for patches and patchJson6902 which will throw error if target is not found #4715

Closed

patches should throw error on missing targets #4379

Closed

stormqueen1990 reviewed Jun 8, 2025

View reviewed changes

adoramshoval mentioned this pull request Jun 14, 2025

feat: add PatchArgs API type to populate patch options #5930

Merged

adoramshoval force-pushed the detect-no-matching-resources branch from 015d04b to a7d3da1 Compare June 14, 2025 08:44

adoramshoval changed the title ~~Detect no matching resources~~ Draft: Detect no matching resources Jun 14, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2025

adoramshoval force-pushed the detect-no-matching-resources branch from a7d3da1 to 8da8556 Compare June 19, 2025 10:32

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2025

laxmikantbpandhare and others added 3 commits August 12, 2025 09:14

rebase

a4d61b8

Rebase laxmikantbpandhare commits on top of master

updated error message according to new discussion

2f127dd

resolved conflicts

adoramshoval force-pushed the detect-no-matching-resources branch from 8da8556 to f329f91 Compare August 12, 2025 15:01

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2025

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 12, 2025

adoramshoval changed the title ~~Draft: Detect no matching resources~~ feat: Detect no matching resources Aug 12, 2025

stormqueen1990 reviewed Aug 23, 2025

View reviewed changes

adoramshoval commented Aug 24, 2025

View reviewed changes

koba1t added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 26, 2025

feat: Detect no matching resources #5917

Are you sure you want to change the base?

feat: Detect no matching resources #5917

Conversation

adoramshoval commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented May 23, 2025

Uh oh!

linux-foundation-easycla bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented May 23, 2025

Uh oh!

k8s-ci-robot commented May 23, 2025

Uh oh!

stormqueen1990 left a comment

Choose a reason for hiding this comment

Uh oh!

adoramshoval commented Jun 13, 2025

Uh oh!

adoramshoval commented Jun 14, 2025

Uh oh!

stormqueen1990 commented Jun 15, 2025

Uh oh!

stormqueen1990 commented Jun 15, 2025

Uh oh!

koba1t commented Jun 16, 2025

Uh oh!

adoramshoval commented Jun 19, 2025

Uh oh!

adoramshoval commented Jun 26, 2025

Uh oh!

koba1t commented Aug 12, 2025

Uh oh!

k8s-ci-robot commented Aug 12, 2025

Uh oh!

adoramshoval commented Aug 12, 2025

Uh oh!

adoramshoval commented Aug 18, 2025

Uh oh!

stormqueen1990 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adoramshoval left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adoramshoval commented Sep 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adoramshoval commented May 23, 2025 •

edited

Loading

linux-foundation-easycla bot commented May 23, 2025 •

edited

Loading