Skip to content

Make sure ResetOpenAPI() is called in tests, even if the tests failed #5923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+1 −1
Open

Make sure ResetOpenAPI() is called in tests, even if the tests failed #5923

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4ee4c1d
Parse `x-kubernetes-list-type` in CRD as the key of strategic merge p…
tsekine354 May 14, 2025
a9808e5
Add a test case under api/krusty for #5878 (#2)
tsekine354 May 16, 2025
c5e332b
revert unnecessary changes
tsekine354 May 16, 2025
f891003
nitpick: revert unnecessary changes / fix typo
tsekine354 May 16, 2025
a61384a
Add a test case for #5904 (#3)
tsekine354 May 19, 2025
878c3ab
Revert "Add a test case for #5904 (#3)" (#4)
tsekine354 May 23, 2025
767b6d1
Fix lint errors (#5)
tsekine354 May 23, 2025
8bbac4a
Fix TestCustomOpenApiFieldWithoutMergePatchExtension whose expected r…
tsekine354 May 23, 2025
4ef77e1
Defer ResetOpenAPI() in tests, so that OpenAPI schema could be reset …
tsekine354 Jun 4, 2025
7491159
revert all unintended changes, caused by some git operation mistakes
tsekine354 Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/krusty/openapicustomschema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ spec:
func runOpenApiTest(t *testing.T, test func(t *testing.T)) {
t.Helper()
openapi.ResetOpenAPI()
defer openapi.ResetOpenAPI()
test(t)
openapi.ResetOpenAPI()
}

// Test for issue #2825
Expand Down