Skip to content

feat(rbac): add permissions for daemonsets finalizers in worker role #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(rbac): add permissions for daemonsets finalizers in worker role #2198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions deployment/helm/node-feature-discovery/templates/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,12 @@ rules:
- pods
verbs:
- get
- apiGroups:
- apps
resources:
- daemonsets/finalizers
verbs:
- get
- update
- delete
Copy link
Preview

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The delete verb on daemonsets/finalizers may be overly permissive. Consider if only get and update verbs are sufficient for setting blockOwnerDeletion, as delete allows removing finalizers from any DaemonSet which could impact cleanup behavior.

Suggested change
- delete

Copilot uses AI. Check for mistakes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

{{- end }}