Calculate new subsetPerZone with the exclusion of existing endpoints (map version) #2937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TortillaZHawaii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
This change is there to fix edge cases when the number of nodes in the zone fluctuates while being nearly equal. Those fluctations cause the `pickSubsetMinRemovals` zone ordering to change - causing constant detach/attach of an endpoint. This "moving" endpoint then causes constant connection draining for ~1/25 of traffic. The fix is to keep existing endpoints as long as the node/subnet pair attached to the endpoint still exists, and only consider unused endpoints for `pickSubsetMinRemovals`.
TortillaZHawaii
force-pushed
the
stabilize-neg-etp-cluster-2
branch
from
07bf9ac to
b5b1a9f
Compare
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is there to fix edge cases when the number of nodes in the zone fluctuates while being nearly equal. Those fluctations cause the
pickSubsetMinRemovalszone ordering to change - causing constant detach/attach of an endpoint. This "moving" endpoint then causes constant connection draining for ~1/25 of traffic.The fix is to keep existing endpoints as long as the node/subnet pair attached to the endpoint still exists, and only consider unused endpoints for
pickSubsetMinRemovals.