Skip to content

feat: for version command add fields #17477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

huhouhua
Copy link
Contributor

@huhouhua huhouhua commented Jul 8, 2025

Ref: #17467

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @huhouhua. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johngmyers for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab July 8, 2025 20:52
@huhouhua
Copy link
Contributor Author

huhouhua commented Jul 8, 2025

@hakman can you review my pull request 🙇

@ameukam
Copy link
Member

ameukam commented Jul 9, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2025
@huhouhua
Copy link
Contributor Author

huhouhua commented Jul 9, 2025

/retest-required

@huhouhua huhouhua requested a review from ameukam July 9, 2025 08:07
Apply suggestions from code review

Co-authored-by: Arnaud M. <[email protected]>
@huhouhua huhouhua force-pushed the feat-version-support-fields branch from 1bb2725 to c4fbaf9 Compare July 9, 2025 08:25
@huhouhua
Copy link
Contributor Author

huhouhua commented Jul 9, 2025

/retest

@huhouhua
Copy link
Contributor Author

huhouhua commented Jul 9, 2025

@ameukam @hakman review the workflows

@hakman
Copy link
Member

hakman commented Jul 9, 2025

@huhouhua I think this is a good start, though we don't really use those binaries for anything other than debugging.
Releases are done using ko, so I would see this change more like this example: kubernetes-sigs/aws-load-balancer-controller#2955.

@huhouhua
Copy link
Contributor Author

huhouhua commented Jul 9, 2025

@huhouhua I think this is a good start, though we don't really use those binaries for anything other than debugging. Releases are done using ko, so I would see this change more like this example: kubernetes-sigs/aws-load-balancer-controller#2955.

Please confirm, do all the instructions using ko build in the makefile need to be modified

@hakman
Copy link
Member

hakman commented Jul 9, 2025

Ah, wait. Let's start with what you have now, but could you limit the changes to the kops binary in this PR?
Will try to look deeper later this week. Sorry for the initial confusion.

@huhouhua
Copy link
Contributor Author

huhouhua commented Jul 9, 2025

Ah, wait. Let's start with what you have now, but could you limit the changes to the kops binary in this PR? Will try to look deeper later this week. Sorry for the initial confusion.

Don't merge it yet, wait until it's confirmed later this week before modifying it

@hakman
Copy link
Member

hakman commented Jul 9, 2025

sure, no worries, need to add some comments for sure.

@huhouhua
Copy link
Contributor Author

@hakman Is the command definition for kops release in the makefile?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 13, 2025

@huhouhua: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-test 38e9a7a link true /test pull-kops-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@huhouhua
Copy link
Contributor Author

@hakman @justinsb Hi
I’d like to follow up on this PR. Please let me know if there’s anything that needs adjustment. Thank you

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants