-
Notifications
You must be signed in to change notification settings - Fork 4.7k
coredns: Relax zonal topologySpreadConstraints #17554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override pull-kops-e2e-aws-upgrade-k132-ko132-to-klatest-kolatest-many-addons |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-upgrade-k132-ko132-to-klatest-kolatest-many-addons In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I just hit this on a test cluster where all its nodes are in a single availability zone, so only one of the 3 coredns pods would start. Rather than removing the constraint, would it be better to keep it and just set |
/hold |
The downside of ScheduleAnyway is that if there is room on an existing node in an undesired zone, k8s will schedule it there rather than keep it in Pending for your autoscaler to launch a new node in the desired zone. Some users may find this acceptable while others may not. |
/cc @rifelpet @ameukam