Compatiblity fix: Always use OpenAPIModelName() functions if they are avalable #564
+124
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
jpbetz
force-pushed
the
backward-compat-model-names
branch
from
398aeff to
ad5ab13
Compare
|
Looks like the CI failure is legitimate. Do the golden files need to be updated? |
Ah, yes, I added some comments last minute and they show up as description fields. Fixed. |
jpbetz
force-pushed
the
backward-compat-model-names
branch
from
7088feb to
87d33b5
Compare
jpbetz
force-pushed
the
backward-compat-model-names
branch
from
87d33b5 to
62a9a4e
Compare
jpbetz
force-pushed
the
backward-compat-model-names
branch
from
62a9a4e to
2a895cc
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jefftree, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered in k/k that #563 is not fully backward compatible. Before migrating sample-apiserver to use the new model names approach, it's openapi serving was broken.
The problem was once OpenAPIModelName() functions were generated for the core types, sample-apiserver's openapi had a mix of types with OpenAPIModelName() functions (the core types) and without (the sample-apiserver types).
So to be fully compatible, this PR detects OpenAPIModelName() functions and always uses them when available so that projects that import types from core or other projects continue to work even when not using
+k8s:openapi-model-packagefor their own types.