-
Notifications
You must be signed in to change notification settings - Fork 520
feat: add includeLabels option to release-notes #4089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add includeLabels option to release-notes #4089
Conversation
30d814a
to
5327a67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @puerco Let me know if this isn't code complete for adding a new release-notes config flag, this is my first PR against this project! (Also if there's anything additional I should do to advocate for new feature inclusion, happy to...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Some very nitty comments to match the style with other things, but otherwise LGTM!
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5327a67
to
9dc037d
Compare
@xmudrii Thanks for the review! Tested a local build and it's doing what we want in the kubernetes/autoscaling project:
First example is without the --include-labels filter (29 results), second example has it (16 results). FYI @towca @omerap12 @adrianmoisey @elmiko this will help us to better automate releases across CAS/VPA |
What type of PR is this?
/kind feature
What this PR does / why we need it:
For monorepo github repositories in the Kubernetes ecosystem that share a common master/main branch, we need a way to differentiate commits in order to use
release-notes
in a fully automated way.This PR introduces a user-configurable labels filter that can be used to instruct release-notes "only include commits that originate from PRs w/ one of these labels" in the generated output.
In particular, this would enable SIG Autoscaling to leverage
release-notes
for the variety of projects under a common repository (e.g., Cluster Autoscaler, Vertical Pod Autoscaling).Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?