-
Notifications
You must be signed in to change notification settings - Fork 15k
Try to clarify the status of ipvs kube-proxy #51974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
higher throughput of network traffic. | ||
|
||
{{< note >}} | ||
The `ipvs` proxy mode was an experiment in providing a Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (can wait for a follow-up PR)
I'd put this note just after This proxy mode is only available on Linux nodes.
functionality correctly. At some point in the future, it is expected | ||
to be formally deprecated as a feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionality correctly. At some point in the future, it is expected | |
to be formally deprecated as a feature. | |
functionality correctly. |
We could make an exception to policy, but normally we avoid statements about the future. I'm on the fence but overall I prefer not to recommend making an exception here.
If we want to guide people to nftables, a blog article about adopting it would be better (and, to be clear @danwinship - you're absolutely welcome to write one, but it's equally valid to nudge other folk towards that work). Blog articles get noticed in a way that notices buried like this one don't, and they are allowed to talk about ambitions, plans, expectations, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already one https://kubernetes.io/blog/2025/02/28/nftables-kube-proxy/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I had added a comment here and then forgot to publish it... Anyway, yes, if we don't want to talk about the future, then we should probably just wait until the deprecation actually officially happens, which will presumably be in 1.35. I was just pushing this now because there was some pressure toward making it clearer in the docs that ipvs is no longer fully supported. (I don't think it makes sense to say "it's not fully supported but there's no particular reason for this, nope, nothing to see here".)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's explain the shortcoming now and hyperlink to the blog article from earlier this year.
Blog articles carry a date and people shouldn't be surprised if they become stale; docs should be - at least for this project - timeless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One problem with "At some point in the future, it is expected to be formally deprecated as a feature." is that at the moment we deprecate IPVS mode, the docs are relevant to people — and also wrong (they will imply the deprecation hasn't happened).
We really should avoid it.
/lgtm leave to Tim and Dan to flesh out the open comment, but it looks really well explained |
LGTM label has been added. Git tree hash: fed90206b6b602d1abba4db5b3540953f4511ff5
|
OK, so the status of the kube-proxy ipvs backend is:
So this tries to explain that some. I'm not particularly attached to any of the specific text here; consider this a starting point.
Fixes #51917
/assign @lmktfy @aojea
/sig network