Skip to content

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Oct 10, 2025

Add a new section about CoreDNS customizations.
Include examples of how it is possible to customize coredns.

this is not a 1.35 feature, we added it back in 1.31, but this PR diff got lost likely in the rather convoluted branches merges that are done for k/website each release (i don't know if these are still done):

i believe this is the second time i've this happen, so it's a bit of a concern that docs may get lost randomly.
cc @kubernetes/sig-docs-en-owners FYI

/cc @rikatz @SataQiu for review.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Oct 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2025
Copy link

netlify bot commented Oct 10, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fb873d3
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68ecec8f7d7435000872ce59
😎 Deploy Preview https://deploy-preview-52681--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rikatz
Copy link
Member

rikatz commented Oct 10, 2025

/lgtm
Thanks for taking care of it!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f6f3ae82d6d3d810bdcf781cb2574d258c94a3b8

@neolit123 neolit123 force-pushed the 1.35-add-customization-section-for-coredns branch from 002ea7a to 38b2aba Compare October 13, 2025 12:09
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2025
@k8s-ci-robot k8s-ci-robot requested a review from rikatz October 13, 2025 12:09
Add a new section about CoreDNS customizations.
Include examples of how it is possible to customize coredns.
@neolit123 neolit123 force-pushed the 1.35-add-customization-section-for-coredns branch from 38b2aba to fb873d3 Compare October 13, 2025 12:11
@neolit123 neolit123 changed the title kubeadm: add coredns section to the componenbt customize page kubeadm: add coredns section to the component customize page Oct 13, 2025
@neolit123
Copy link
Member Author

/cc @SataQiu @rikatz
/assign @tengqm

PTAL again for LGTM/approve.

@tengqm
Copy link
Contributor

tengqm commented Oct 13, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@windsonsea
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c18a549e57f0c13dbd679431b5aed6cd35f62d11

@k8s-ci-robot k8s-ci-robot merged commit 27b261d into kubernetes:main Oct 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants