chore: move packages to internal #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not be exposing all code as a public API. Leave just the apis directory and the Harness type in pkg/ to avoid the single active user that I could find. When doing this, flatten the structure by moving packages under the `pkg/test` package directly into `internal`. Signed-off-by: Marcin Owsiany <[email protected]>
Signed-off-by: Marcin Owsiany <[email protected]>
porridge
force-pushed
the
porridge/pkg-reorg
branch
from
e9a7a6c to
a991283
Compare
vladbologa
requested changes
Oct 16, 2025
Signed-off-by: Marcin Owsiany <[email protected]>
vladbologa
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We should not be exposing all code as a public API.
Leave just the apis directory and the Harness type in pkg/ to avoid the single active user that I could find.
When doing this, flatten the structure by moving packages under the
pkg/testpackage directly intointernal.