Skip to content

Conversation

sakno
Copy link
Contributor

@sakno sakno commented Oct 7, 2025

Changed: Added Azure provider to store database archived transaction log files

@linear
Copy link

linear bot commented Oct 7, 2025

@sakno sakno marked this pull request as ready for review October 8, 2025 13:53
@sakno sakno requested a review from a team as a code owner October 8, 2025 13:53
<PackageVersion Include="Extensions.MudBlazor.StaticInput" Version="3.2.1" />
<PackageVersion Include="FluentAssertions" Version="6.12.2" />
<PackageVersion Include="FluentAssertions.Analyzers" Version="0.34.1" />
<PackageVersion Include="FluentAssertions.Analyzers" Version="0.33.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the version downgrade intentional? (the new version was probably added to master recently)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's intentional. I have incompatibility problems with my local .NET SDK 8.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2025

Deploying eventstore with  Cloudflare Pages  Cloudflare Pages

Latest commit: 08e72b3
Status: ✅  Deploy successful!
Preview URL: https://ffc22c62.eventstore.pages.dev
Branch Preview URL: https://sakno-archive-azure.eventstore.pages.dev

View logs

Note: some code paths are not currently possible due to the way the options are parsed. they have been added for consistency with the `StorageType` enum
Copy link
Member

@shaan1337 shaan1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I've tested only with
Authentication: Default (using Azure CLI) and
Authentication: ConnectionString

Example configs:

  1. ConnectionString authentication
  StorageType: Azure
  Azure:
    Container: archiver-unit-tests
    Authentication: ConnectionString
    ConnectionStringOrServiceUrl: DefaultEndpointsProtocol=https;AccountName=archiverunittests;AccountKey=<Account Key>;EndpointSuffix=core.windows.net
  1. Default authentication + Azure CLI
  StorageType: Azure
  Azure:
    Container: archiver-unit-tests
    Authentication: Default
    ConnectionStringOrServiceUrl: https://archiverunittests.blob.core.windows.net/

This requires logging in with Azure CLI on the machine:

$ az login

and setting the required permissions for the user to be able to read/write to the container:

az role assignment create \
  --assignee <your-user-email-or-object-id> \
  --role "Storage Blob Data Contributor" \
  --scope /subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Storage/storageAccounts/<storage-account-name>

(You'll need to logout and login again to the Azure CLI after applying the permissions)

@sakno sakno merged commit b5831c5 into master Oct 13, 2025
7 of 9 checks passed
@sakno sakno deleted the sakno/archive-azure branch October 13, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants