Skip to content

Add a link on title to compare changes between two releases #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add a link on title to compare changes between two releases #78

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f4aa3b5
add getRepositoryUrl function
Apr 5, 2018
b8aaf52
add compare url to tag
Apr 5, 2018
67572e9
A tag may contains several PRs
Apr 5, 2018
3c9307f
remove unneeded codes
Apr 5, 2018
82d026b
fix first tag is not added a link in some situation
Dec 21, 2018
302da60
Update index.js
khiav223577 Dec 21, 2018
860bf7b
Merge branch 'master' into feature/view_changes_link
Apr 4, 2019
f6fae5a
Merge remote-tracking branch 'origin/patch-1'
Oct 15, 2020
0568c7a
Merge remote-tracking branch 'upstream/master' into feature/view_chan…
Dec 31, 2020
ded3478
Merge branch 'master' into feature/view_changes_link
Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 29 additions & 8 deletions bin/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,11 @@ var getAllCommits = function() {
});
};

var getRepositoryUrl = function() {
var host = (opts.host === 'api.github.com') ? 'github.com' : opts.host;
return "https://"+host+"/"+opts.owner+"/"+opts.repository;
};

var getData = function() {
if (opts.data === 'commits') return getAllCommits();
return getPullRequests();
Expand All @@ -190,14 +195,29 @@ var tagger = function(sortedTags, data) {
if (opts.data === 'commits') date = moment(data.commit.committer.date);
else date = moment(data.merged_at);

var current = null;
var prevTag = null;
var currTag = null;
for (var i=0, len=sortedTags.length; i < len; i++) {
var tag = sortedTags[i];
prevTag = tag;
if (tag.date < date) break;
current = tag;
currTag = tag;
}
if (!current) current = {name: opts.tagName, date: currentDate};
return current;
if (!currTag) currTag = {name: opts.tagName, date: currentDate};
return { currTag: currTag, prevTag: prevTag };
};

var getPrTag = function(pr) {
var url = (function(){
if (pr.tag === null) return;
if (pr.prevTag == null) return;
var currentTagName = (pr.tag.name === 'upcoming' ? 'HEAD' : pr.tag.name);
var previousTagName = pr.prevTag.name;
return getRepositoryUrl()+'/compare/'+previousTagName+'...'+currentTagName;
})();

if (url) return "[" + pr.tag.name + "](" + url + ")";
return pr.tag.name;
};

var prFormatter = function(data) {
Expand All @@ -211,7 +231,7 @@ var prFormatter = function(data) {
output+= "\n";
} else if (pr.tag.name != currentTagName) {
currentTagName = pr.tag.name;
output+= "\n### " + pr.tag.name
output+= "\n### " + getPrTag(pr);
output+= " " + pr.tag.date.tz(opts.timeZone).format(opts.dateFormat);
output+= "\n";
}
Expand Down Expand Up @@ -347,8 +367,7 @@ var commitFormatter = function(data) {
}


var host = (opts.host === 'api.github.com') ? 'github.com' : opts.host;
var url = "https://"+host+"/"+opts.owner+"/"+opts.repository+"/pull/"+prNumber;
var url = getRepositoryUrl()+"/pull/"+prNumber;
output += "- [#" + prNumber + "](" + url + ") " + message;

if (authors.length) {
Expand Down Expand Up @@ -410,7 +429,9 @@ var task = function() {
return data;
})
.map(function(data){
data.tag = tagger(allTags, data);
var tagInfo = tagger(allTags, data);
data.prevTag = tagInfo.prevTag;
data.tag = tagInfo.currTag;
data.tagDate = data.tag.date;
return data;
})
Expand Down