Skip to content

Use Enum.each instead of Enum.map where possible #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Enum.each instead of Enum.map where possible #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/nsq/consumer/connections.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ defmodule NSQ.Consumer.Connections do
def close(cons_state) do
Logger.info "Closing connections for consumer #{inspect self()}"
connections = get(cons_state)
Enum.map connections, fn({_, conn_pid}) ->
Enum.each connections, fn({_, conn_pid}) ->
Task.start_link(NSQ.Connection, :close, [conn_pid])
end
{:ok, %{cons_state | stop_flag: true}}
Expand Down Expand Up @@ -260,7 +260,7 @@ defmodule NSQ.Consumer.Connections do
"""
@spec delete_dead(C.state) :: {:ok, C.state}
def delete_dead(state) do
Enum.map get(state), fn({conn_id, pid}) ->
Enum.each get(state), fn({conn_id, pid}) ->
unless Process.alive?(pid) do
Supervisor.delete_child(state.conn_sup_pid, conn_id)
end
Expand All @@ -275,7 +275,7 @@ defmodule NSQ.Consumer.Connections do


def reconnect_failed(state) do
Enum.map get(state), fn({_, pid}) ->
Enum.each get(state), fn({_, pid}) ->
if Process.alive?(pid), do: GenServer.cast(pid, :reconnect)
end
{:ok, state}
Expand Down