Skip to content

Make kaocha.jit/jit thread-safe #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make kaocha.jit/jit thread-safe #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
## Fixed

- Fix beholder watch functionality that would cause a NullPointerException earlier.
- Make `kaocha.jit/jit` thread-safe in Clojure 1.10+. For lower versions, best effort with printed warning.

## Changed

Expand Down
7 changes: 6 additions & 1 deletion src/kaocha/jit.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,10 @@
"Just in time loading of dependencies."
[sym]
`(do
(require '~(symbol (namespace sym)))
(locking ~(if (find-var 'clojure.core/requiring-resolve)
'clojure.lang.RT/REQUIRE_LOCK
(do (binding [*err* *out*]
(println "WARNING: kaocha.jit is not thread-safe before Clojure 1.10"))
::lock))
(require '~(symbol (namespace sym))))
(find-var '~sym)))
Loading