Skip to content

Conversation

von-development
Copy link
Contributor

Description

Updated docstrings in langchain-google-community to be in accordance with the new reference docs site.

  • Updated 22 files docsrtrings
  • Added cross-references to base classes
  • Added admonitions for installation, authentication, and security notes
  • Updated code snippets and examples

Relevant issues

Fixes #1237

Type

📖 Documentation

@von-development
Copy link
Contributor Author

Hey @mdrxy! here is the PR for the community pkg for new ref docs.

Working on these docstring updates raised some questions about reference docs patterns:

1. Documenting private method details in class docstrings:
The reference site omits private methods (e.g., _run() for tools, load() for loaders), so users can't see the implementation-specific parameters and return values. Should we add these details in the class docstring with sections like "Tool Output/Input"? We could also set inherited_members: false in langchain_google_community.md and add admonitions with cross-references to base classes. I tested this locally and it looks more organized.

2. Example detail level in reference docs:
What's the right balance for examples in reference documentation? I left some examples in the Google Sheets folder that might be good reference for this. (Maybe a good idea to develop a standardization doc for future contributors in packages and docs 🙂)

3. Package organization in docs:
I think it would be beneficial to create a dedicated folder structure for langchain-google-community in the docs (and also in the package but that would be some work) with subdirectories organized by component type (document loaders, tools, retrievers, etc.), similar to how other reference docs and integration packages are structured.ed by component type (document loaders, tools, retrievers, etc.), similar to how other integration packages are structured.

PS: Asking this not to give you more trouble, just to say I can help with some of those if they're not already planned

@mdrxy
Copy link
Collaborator

mdrxy commented Oct 20, 2025

@von-development

  1. I'm in favor of your inherited_members: false approach; the more we can keep the pages accessible and not bogged down the better. We'll be giving other pages a similar treatment down the line.
  2. Can you link me to your Google Sheets examples? The ultimate goal is to limit the amount of example/docs content in the source code, instead porting them to the .md pages in the reference folder in the docs repo. I can link an example once I've ported - e.g. the frontmatter content in ChatOpenAI. This should help make the source code more lean.
  3. Yes, agreed that langchain-google-community should be organized. You may want to take a look at the mkdocs.yml nav header to see how this is being done for others (working on some of this today actually)

Appreciate the checking in and feel free to reach out on Slack if quicker

on behalf of the associated account.
See https://python.langchain.com/docs/security for more information.
See [Security Best Practices](https://python.langchain.com/docs/security)
Copy link
Collaborator

@mdrxy mdrxy Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to update this (and all other links) once the security page is ported (cc @eyurtsev)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added TODO comments in calendar/toolkit.py and
gmail/toolkit.py to update these links once the security page is ported.

@von-development
Copy link
Contributor Author

@mdrxy I'll keep an eye out for the .md patch from ChatOpenAI and take a look at mkdocs.yml to help with the docs for the Google packages

Google Sheets examples in this PR:

  • sheets/create_spreadsheet_tool.py (86-123)
  • sheets/read_sheet_tools.py (215-253, 395-421, 652-686)

Thanks again for the review and clarifications!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating reference docs for new site

2 participants