Skip to content

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Aug 4, 2025

No description provided.

Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
langchain Ready Ready Preview Comment Sep 8, 2025 9:12pm

Copy link

codspeed-hq bot commented Aug 4, 2025

CodSpeed WallTime Performance Report

Merging #32379 will not alter performance

Comparing cbornet:langchain-mypy-warnings (8950e9c) with wip-v1.0 (8509efa)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Aug 4, 2025

CodSpeed Instrumentation Performance Report

Merging #32379 will not alter performance

Comparing cbornet:langchain-mypy-warnings (8950e9c) with wip-v1.0 (8509efa)

Summary

✅ 14 untouched benchmarks

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Pydantic v1 compatibility code and deprecation warnings to modernize the LangChain codebase. The changes focus on cleaning up legacy Pydantic patterns that are no longer needed.

  • Removes mypy configuration that was treating deprecation warnings as notes
  • Eliminates Pydantic v1 compatibility checks and fallback methods
  • Updates method calls to use modern Pydantic v2 equivalents

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Removes mypy config for deprecation warning handling
utils/pydantic.py Adds type ignore comment for deprecated import
output_parsers/yaml.py Removes Pydantic v1 compatibility checks for validation and schema methods
chains/openai_functions/qa_with_structure.py Removes fallback to legacy schema() method
chains/openai_functions/citation_fuzzy_match.py Removes fallback to legacy schema() method
chains/base.py Updates deprecated dict() method to modern model_dump()

@cbornet cbornet force-pushed the langchain-mypy-warnings branch from 892d53a to 6a765e1 Compare August 16, 2025 11:00
@mdrxy mdrxy added the langchain Related to the package `langchain` label Aug 20, 2025
@mdrxy mdrxy added this to the v1 milestone Aug 20, 2025
@mdrxy mdrxy changed the base branch from master to wip-v1.0 August 20, 2025 02:05
@mdrxy mdrxy merged commit 3c189f0 into langchain-ai:wip-v1.0 Sep 8, 2025
39 of 40 checks passed
@cbornet cbornet deleted the langchain-mypy-warnings branch September 9, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

langchain Related to the package `langchain`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants