-
Notifications
You must be signed in to change notification settings - Fork 19.2k
feat(core): output_version
on invoke / model call
#32694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdrxy
wants to merge
89
commits into
wip-v1.0
Choose a base branch
from
mdrxy/call-version
base: wip-v1.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
7090060
select changes from wip-v0.4/core
ccurme 54a3c5f
x
ccurme f8244b9
type required on tool_call_chunk; keep messages.tool.ToolCallChunk
ccurme 1b9ec25
update init on aimessage
ccurme 8426db4
update init on HumanMessage, SystemMessage, ToolMessage
ccurme 91b2bb3
Merge branch 'wip-v1.0' into cc/1.0/standard_content
ccurme 0ddab9f
start on duplicate content
ccurme 98d5f46
Revert "start on duplicate content"
ccurme 6eaa172
implement output_version on BaseChatModel
ccurme 3ae7535
openai: pull in _compat from 0.4 branch
ccurme c1d65a7
x
ccurme c0e4361
core: populate tool_calls when initializing AIMessage via content_blocks
ccurme 5c961ca
update test_base
ccurme 0c7294f
openai: pull in responses api integration tests from 0.4 branch
ccurme 3ae37b5
openai: integration tests pass
ccurme 2f604eb
openai: carry over refusals fix
ccurme 803d19f
Merge branch 'wip-v1.0' into cc/1.0/standard_content
ccurme 153db48
openai: misc fixes for computer calls and custom tools
ccurme 0aac20e
openai: tool calls in progress
ccurme 624300c
core: populate tool_call_chunks in content_blocks
ccurme d111965
Merge branch 'wip-v1.0' into cc/1.0/standard_content
mdrxy 7e39cd1
feat: allow kwargs on content block factories (#32568)
mdrxy 601fa7d
Merge branch 'wip-v1.0' into cc/1.0/standard_content
mdrxy c9e847f
chore: format `output_version` docstring
mdrxy 8d11059
chore: more content block docstring formatting
mdrxy 3db8c60
chore: more content block formatting
mdrxy 301a425
snapshot
mdrxy a3b20b0
clean up id test
mdrxy 8fc1973
test: add note about for tuple conversion in ToolMessage
mdrxy 86252d2
refactor: move ID prefixes
mdrxy f691dc3
refactor: make `ensure_id` public
mdrxy 7a8c639
clarify: meaning of provider
mdrxy 987031f
fix: `_LC_ID_PREFIX` back
mdrxy 08cd5bb
clarify intent of `extras` under data blocks
mdrxy 7f9727e
refactor: `is_data_content_block`
mdrxy 00345c4
tests: add more data content block tests
mdrxy 0199b56
rfc `test_utils` to make clearer what was existing before and after, …
mdrxy 2375c3a
add note
mdrxy aca7c1f
fix(core): temporarily fix tests (#32589)
ccurme aeea0e3
fix(langchain): fix tests on standard content branch (#32590)
ccurme 4790c72
feat(core): lazy-load standard content (#32570)
ccurme 8ee0cbb
refactor(core): prefixes (#32597)
mdrxy 0e6c172
refactor(core): prefixes, again (#32599)
mdrxy 313ed7b
Merge branch 'wip-v1.0' into cc/1.0/standard_content
mdrxy 27d81cf
test(openai): address some type issues in tests (#32601)
mdrxy 43b9d3d
feat(core): implement dynamic translator registration for model provi…
mdrxy e41693a
Merge branch 'wip-v1.0' into cc/1.0/standard_content
ccurme 0444e26
refactor: convert message content inside `BaseChatModel` (#32606)
ccurme 3c8edbe
Merge branch 'wip-v1.0' into cc/1.0/standard_content
ccurme 5bcf7d0
refactor(core): data block handling, normalize message formats, strip…
mdrxy 26833f2
feat(anthropic): v1 support (#32623)
ccurme 62d746e
feat(core): (v1) restore separate type for AIMessage.tool_calls (#32668)
ccurme 2d9fe70
Merge branch 'wip-v1.0' into cc/1.0/standard_content
ccurme 4e0fd33
fix: update `content_blocks` property docstring
mdrxy 5ef18e8
feat(core): add `.text` property, introduce `TextAccessor` for backwa…
mdrxy 97bd2cf
fix(core): (v1) fix PDF input translation for openai chat completions…
ccurme fe9599f
feat(core): parse `tool_call_chunks` in content in aggregated stream …
ccurme c63c3ea
feat(core): (v1) add sentinel value to `output_version` (#32692)
ccurme 518f4df
.
mdrxy f1b676c
.
mdrxy 706ea1b
.
mdrxy df3db47
Merge branch 'cc/1.0/standard_content' of github.com:langchain-ai/lan…
mdrxy 659d282
standard tests: update multimodal tests
ccurme 19d3a73
.
mdrxy 72b2436
ss
mdrxy 5222d51
.
mdrxy 720d08e
.
mdrxy 620779f
.
mdrxy dc5ac66
.
mdrxy 2bbd034
fix(core): (v1) invoke callback prior to yielding final chunk (#32695)
ccurme 3955157
Merge branch 'wip-v1.0' into cc/1.0/standard_content
mdrxy fa5d49f
Merge branch 'cc/1.0/standard_content' of github.com:langchain-ai/lan…
mdrxy 447db13
feat(openai): (v1) support `content_blocks` on legacy v0 responses AP…
ccurme 18d1cf2
.
mdrxy 04bcccf
Merge branch 'cc/1.0/standard_content' of github.com:langchain-ai/lan…
mdrxy e49156e
chore: rfc to use `.text` instead of `.text()` (#32699)
mdrxy 2d450d4
fix(core): (v1) finish test (#32701)
ccurme 8a14148
.
mdrxy 32941d6
.
mdrxy 313f5f2
.
mdrxy 8f3674c
Merge branch 'cc/1.0/standard_content' into mdrxy/call-version
mdrxy 419450d
.
mdrxy 624afb1
ss
mdrxy 7f218e2
.
mdrxy e1add11
fix: openai
mdrxy 19e5e96
fix: anthropic
mdrxy 007a3a4
Merge branch 'wip-v1.0' into mdrxy/call-version
mdrxy 4fab33a
Merge branch 'wip-v1.0' into mdrxy/call-version
mdrxy 91d6c05
Merge branch 'wip-v1.0' into mdrxy/call-version
mdrxy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
309 changes: 273 additions & 36 deletions
309
libs/core/langchain_core/language_models/chat_models.py
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BaseChatModel is inserting the output version, right? how would we hit this ValueError?
If a user receives this ValueError, are they just stuck? What can they do?
I think in most other cases in the merging logic we just accept the left value.