Migration to criterion #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented changes to the benchmark tests in src/cpu/ios_macos.rs and transfered them to a new file named ios_macos.rs under the benchmarks/cpu directory. This helps in separating the CPU usage tests from the program file and adhere to the single-responsibility principle. Furthermore, added new dependency 'criterion' in Cargo.toml for benchmarking along with a corresponding bench setup. The removed lines in lib.rs is to allow these modifications, eliminating unnecessary features and dependencies.
…for cpu_ios_macos. ThreadId structure and get_thread_basic_info function in src/cpu/ios_macos.rs file are now publicly accessible, allowing external code to use them. The `pub` keyword was added to the struct and function declarations to make them public. Benchmark test for cpu_ios_macos has been activated in Cargo.toml file by uncommenting respective lines. Update also includes adding dependencies and improving codes in benches/cpu/ios_macos.rs. This commit will support more extensive testing and functionality usage in iOS and MacOS platforms."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request migrates from test Bencher to criterion to avoid using nightly toolchain, however it's necessary to increase minimum supported Rust version to 1.57 according to criterion