Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hey @ayushkamat @rahuldesai1
I'm starting to migrate some of our workflows away from the deprecated
LatchFile
/LatchDir
API toLPath
. I'm appreciating the ways theLPath
API seems to mirror the standard library'spathlib
- it should make for an easy transition.Would you be open to adding an
exists()
method toLPath
, analogous topathlib.Path.exists()
?There seems to be a couple ways it could be implemented - I used
self.fetch_metadata()
, but we could just as easily borrow the existence check fromLPath.mkdirp()
which usesNodeData.exists()
. I thought it'd be preferable to useself.fetch_metadata()
because when the user checks if a path exists, then the metadata will be cached for any following operations.Let me know if there are any edge cases (not sure if mounts or account roots need special handling), or if there are any tests I should add or update.