fix: Correctly handle a wrapper name without a wrapper version. #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
changed the base branch from
rlamb/sdk-1502/handle-null-payload
to
rlamb/hooks-contract-tests
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…erly handle a missing version.
kinyoklion
force-pushed
the
rlamb/fix-wrapper-when-only-name
branch
from
e7e9b28 to
86ca2a9
Compare
keelerm84
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: Correctly handle a wrapper name without a wrapper version.
chore: Add support for the wrapper contract tests.
END_COMMIT_OVERRIDE
Note
Properly handle wrapper name without version in HTTP headers and add wrapper config/capability to contract tests.
HttpPropertiesBuilder::Build: SetX-LaunchDarkly-Wrapperto justwrapper_namewhenwrapper_versionis empty; otherwisename/version.ConfigWrapperand optionalconfiguration.wrapperinConfigParams.HttpProperties().WrapperName/WrapperVersionwhenconfiguration.wrapperprovided (client and server)."wrapper"in client and server test services.Written by Cursor Bugbot for commit 2154d6e. This will update automatically on new commits. Configure here.