-
Notifications
You must be signed in to change notification settings - Fork 9
feat(icons): add script to automatically pull icons from Figma #1747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthewferry
wants to merge
33
commits into
main
Choose a base branch
from
mf/feat/icons-automation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,802
−2,445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e3839d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nhironaka
approved these changes
Aug 21, 2025
zmdavis
reviewed
Aug 21, 2025
commit: |
Size Change: 0 B Total Size: 530 kB ℹ️ View Unchanged
|
zmdavis
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a script to pull icons from Figma which can be run with a workflow_dispatch GitHub action or via command line locally. This will make it easier for adding icons so all you need to do is run the script or action. It does require that icons be merged into LaunchPad Figma before being able to add them, but I think that's a constraint that feels more like a feature than a bug so our icons don't get out of sync (when initially run, there were multiple icons in Figma, but not in the package and vice versa). This will also reduce the mistakes that are often added in icon PRs such as not putting symbols in alphabetical order or drift between figma component names and icon ids.
What it does:
How to use if running locally
pnpm nx run @launchpad-ui/icons:sync
TODO/Questions: