Page/theme changer #1146
Page/theme changer #1146
Conversation
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
ShivanshCharak
force-pushed
the
page/theme-changer
branch
from
e059866 to
544b5c1
Compare
|
Related issue: #1006 |
|
@ShivanshCharak ant type os recording |
|
@saurabhraghuvanshii video recording ? |
There was a problem hiding this comment.
Thank you for the effort! However, I believe the pull request (PR) has deviated from its original scope quite a bit. For instance, addressing Redux state management for color would be better handled through its own set of issues and pull requests. This is something that needs to be discussed with the maintainers, ideally over Slack or in a meeting. Keeping things concise and to the point will improve the review process and lead to quicker merges.
Lastly, please attach screenshots.
examples/next-12/package.json
Outdated
There was a problem hiding this comment.
Why makes changes to package.json?
There was a problem hiding this comment.
I tried to install tailwind(which i unintsalled later) for css, Which by mistake updated the version to the latest version, when i reverted back to old version i thought it is using next 12 version, ps forgot to remove auto prefixer
There was a problem hiding this comment.
cool, then revert it to original, so as to ensure consistency
yes |
|
|
@ShivanshCharak looks good just apply justion from @RanitMukherjee and take care of code formating and also revert next version. thanks |
|
@ShivanshCharak there are many lints problem, please linnt the file then commit, it hard to reviews |
Signed-off-by: Shivansh Charak <[email protected]>
| }; | ||
| const {setMode,mode} = useContext(ThemeContext) | ||
| const toggleMode= ()=>{ | ||
| setMode((prev)=>prev==="dark"?"light":"dark") |
There was a problem hiding this comment.
| setMode((prev)=>prev==="dark"?"light":"dark") | |
| setMode((prev) => (prev === 'dark' ? 'light' : 'dark')); |
| import DarkModeIcon from '@mui/icons-material/DarkMode'; | ||
| import LightModeIcon from '@mui/icons-material/LightMode'; | ||
| import { AppThemeContext, ThemeContext } from '@/lib/context/AppThemeContext'; |
There was a problem hiding this comment.
| import { AppThemeContext, ThemeContext } from '@/lib/context/AppThemeContext'; | |
| import { ThemeContext } from '@/lib/context/AppThemeContext'; |
examples/next-12/tsconfig.json
Outdated
| "next-env.d.ts", | ||
| "**/*.ts", | ||
| "**/*.tsx" | ||
| , "lib/context/AppThemeContext.jsxx" ], |
There was a problem hiding this comment.
| , "lib/context/AppThemeContext.jsxx" ], | |
| , "lib/context/AppThemeContext.jsx" ], |
|
|
||
| import { useDispatch, useSelector } from 'react-redux'; |
There was a problem hiding this comment.
| import { useDispatch, useSelector } from 'react-redux'; |
where you're using it?
Signed-off-by: Shivansh Charak <[email protected]>
Signed-off-by: Shivansh Charak <[email protected]>
Page/theme changer upgrade of Pr #1146
Notes for Reviewers
This PR fixes #
Signed commits