[WIP] Add proof step verification. #85
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify each proof step in tactic mode. Roughly, the idea for step
(old :: ProofSnapshot, new :: ProofSnapshot)
is to:old
which no longer exist innew
. For each one:new
. For each metavariable in the assignment:new
, it's fine and we do nothing since we can assume it will be solved in future steps. In this case, we replace it withsorry
in the assignment so that the expression can be sent to kernel.sorry
to kernel for a type check.Compared to #63, this approach could eliminate false negatives like https://github.com/leanprover-community/repl/blob/master/test/name_generator.in, where checking the whole proof term doesn't work since in a
have
branch we don't see the metavariable assignments from the main branch.