Skip to content

Refactored schedule check refresh input box to use an id instead of a… #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2025
Merged

Refactored schedule check refresh input box to use an id instead of a… #3898

merged 3 commits into from
Sep 24, 2025

Conversation

@samalarussa
Copy link
Contributor

… name attribute to establish specificity. Fixes #3866

@willgearty willgearty mentioned this pull request Sep 9, 2025
Open
kkbrum
kkbrum requested changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@kkbrum kkbrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The textbox looks great, but unfortunately the changes seem to have broken the functionality (at least for me). When I hit "start auto refresh", all of the scheduling checks get upset and refuse to load. I checked that this does not occur on main.

@willgearty
Copy link
Member

willgearty commented Sep 19, 2025 •
edited
Loading

I think this page uses React.js, so I think the name attribute is important for that.

willgearty
willgearty approved these changes Sep 24, 2025
View reviewed changes
Copy link
Member

@willgearty willgearty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now, thanks!

@willgearty willgearty merged commit 69f1cc0 into main Sep 24, 2025
5 checks passed
@willgearty willgearty deleted the fix_schedule_check_refresh_width branch September 24, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkbrum kkbrum kkbrum requested changes

@willgearty willgearty willgearty approved these changes

Assignees

@samalarussa samalarussa

Labels

UserInterface

Projects

None yet

Milestone

Stable Release 16 fixes fixes

Development

Successfully merging this pull request may close these issues.

Refresh cycle textbox input is poorly formatted on the scheduling checks page

4 participants

@samalarussa @willgearty @kkbrum